summaryrefslogtreecommitdiffstats
path: root/net/ipv4
diff options
context:
space:
mode:
authorPatrick McHardy2007-07-25 00:29:55 +0200
committerDavid S. Miller2007-07-25 00:29:55 +0200
commit7e2acc7e2711d51705373ac201333c9a0ebd3950 (patch)
tree06bd3d776970a2e09bfca5c67dad4490fd1ea7c0 /net/ipv4
parent[TCPv6] MD5SIG: Ensure to reset allocation count to avoid panic. (diff)
downloadkernel-qcow2-linux-7e2acc7e2711d51705373ac201333c9a0ebd3950.tar.gz
kernel-qcow2-linux-7e2acc7e2711d51705373ac201333c9a0ebd3950.tar.xz
kernel-qcow2-linux-7e2acc7e2711d51705373ac201333c9a0ebd3950.zip
[NETFILTER]: Fix logging regression
Loading one of the LOG target fails if a different target has already registered itself as backend for the same family. This can affect the ipt_LOG and ipt_ULOG modules when both are loaded. Reported and tested by: <t.artem@mailcity.com> Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4')
-rw-r--r--net/ipv4/netfilter/ipt_LOG.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/net/ipv4/netfilter/ipt_LOG.c b/net/ipv4/netfilter/ipt_LOG.c
index 5937ad150b9f..127a5e89bf14 100644
--- a/net/ipv4/netfilter/ipt_LOG.c
+++ b/net/ipv4/netfilter/ipt_LOG.c
@@ -479,10 +479,8 @@ static int __init ipt_log_init(void)
ret = xt_register_target(&ipt_log_reg);
if (ret < 0)
return ret;
- ret = nf_log_register(PF_INET, &ipt_log_logger);
- if (ret < 0 && ret != -EEXIST)
- xt_unregister_target(&ipt_log_reg);
- return ret;
+ nf_log_register(PF_INET, &ipt_log_logger);
+ return 0;
}
static void __exit ipt_log_fini(void)