diff options
| author | Herbert Xu | 2006-07-12 22:29:56 +0200 |
|---|---|---|
| committer | David S. Miller | 2006-07-12 22:59:04 +0200 |
| commit | b47b2ec19892ffc2b06ebf138ed4aa141275a1c2 (patch) | |
| tree | 86642bccfbfdeb004a1b14b28c6ea15ee091de87 /net/ipv4 | |
| parent | [NETROM] lockdep: fix false positive (diff) | |
| download | kernel-qcow2-linux-b47b2ec19892ffc2b06ebf138ed4aa141275a1c2.tar.gz kernel-qcow2-linux-b47b2ec19892ffc2b06ebf138ed4aa141275a1c2.tar.xz kernel-qcow2-linux-b47b2ec19892ffc2b06ebf138ed4aa141275a1c2.zip | |
[IPV4]: Fix error handling for fib_insert_node call
The error handling around fib_insert_node was broken because we always
zeroed the error before checking it.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4')
| -rw-r--r-- | net/ipv4/fib_trie.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/fib_trie.c b/net/ipv4/fib_trie.c index 1cb65305e102..23fb9d9768e3 100644 --- a/net/ipv4/fib_trie.c +++ b/net/ipv4/fib_trie.c @@ -1252,8 +1252,8 @@ fn_trie_insert(struct fib_table *tb, struct rtmsg *r, struct kern_rta *rta, */ if (!fa_head) { - fa_head = fib_insert_node(t, &err, key, plen); err = 0; + fa_head = fib_insert_node(t, &err, key, plen); if (err) goto out_free_new_fa; } |