diff options
| author | David Ahern | 2018-10-05 05:07:52 +0200 |
|---|---|---|
| committer | David S. Miller | 2018-10-05 06:54:10 +0200 |
| commit | cc5f0eb2164f9aa11fe631f8d905192e0233e262 (patch) | |
| tree | c6544db0c15445adcacaf84bec9a12d11020c584 /net/ipv6/ip6_fib.c | |
| parent | net: common metrics init helper for FIB entries (diff) | |
| download | kernel-qcow2-linux-cc5f0eb2164f9aa11fe631f8d905192e0233e262.tar.gz kernel-qcow2-linux-cc5f0eb2164f9aa11fe631f8d905192e0233e262.tar.xz kernel-qcow2-linux-cc5f0eb2164f9aa11fe631f8d905192e0233e262.zip | |
net: Move free of fib_metrics to helper
Move the refcounting and potential free of dst metrics associated
with a fib entry to a helper and use it in both ipv4 and ipv6.
Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6/ip6_fib.c')
| -rw-r--r-- | net/ipv6/ip6_fib.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c index de063780a175..cf709eadc932 100644 --- a/net/ipv6/ip6_fib.c +++ b/net/ipv6/ip6_fib.c @@ -29,6 +29,7 @@ #include <linux/list.h> #include <linux/slab.h> +#include <net/ip.h> #include <net/ipv6.h> #include <net/ndisc.h> #include <net/addrconf.h> @@ -169,7 +170,6 @@ void fib6_info_destroy_rcu(struct rcu_head *head) { struct fib6_info *f6i = container_of(head, struct fib6_info, rcu); struct rt6_exception_bucket *bucket; - struct dst_metrics *m; WARN_ON(f6i->fib6_node); @@ -201,9 +201,7 @@ void fib6_info_destroy_rcu(struct rcu_head *head) if (f6i->fib6_nh.nh_dev) dev_put(f6i->fib6_nh.nh_dev); - m = f6i->fib6_metrics; - if (m != &dst_default_metrics && refcount_dec_and_test(&m->refcnt)) - kfree(m); + ip_fib_metrics_put(f6i->fib6_metrics); kfree(f6i); } |