diff options
| author | Daniel Borkmann | 2015-01-05 23:57:43 +0100 |
|---|---|---|
| committer | David S. Miller | 2015-01-06 04:55:24 +0100 |
| commit | 0409c9a5a7546043d32e8c46df0dcaf65f97f659 (patch) | |
| tree | d928884ae43414093c2f870bfb8206b65cdc9a30 /net/ipv6/route.c | |
| parent | net: Do not call ndo_dflt_fdb_dump if ndo_fdb_dump is defined (diff) | |
| download | kernel-qcow2-linux-0409c9a5a7546043d32e8c46df0dcaf65f97f659.tar.gz kernel-qcow2-linux-0409c9a5a7546043d32e8c46df0dcaf65f97f659.tar.xz kernel-qcow2-linux-0409c9a5a7546043d32e8c46df0dcaf65f97f659.zip | |
net: fib6: fib6_commit_metrics: fix potential NULL pointer dereference
When IPv6 host routes with metrics attached are being added, we fetch
the metrics store from the dst via COW through dst_metrics_write_ptr(),
added through commit e5fd387ad5b3.
One remaining problem here is that we actually call into inet_getpeer()
and may end up allocating/creating a new peer from the kmemcache, which
may fail.
Example trace from perf probe (inet_getpeer:41) where create is 1:
ip 6877 [002] 4221.391591: probe:inet_getpeer: (ffffffff8165e293)
85e294 inet_getpeer.part.7 (<- kmem_cache_alloc())
85e578 inet_getpeer
8eb333 ipv6_cow_metrics
8f10ff fib6_commit_metrics
Therefore, a check for NULL on the return of dst_metrics_write_ptr()
is necessary here.
Joint work with Florian Westphal.
Fixes: e5fd387ad5b3 ("ipv6: do not overwrite inetpeer metrics prematurely")
Cc: Michal Kubeček <mkubecek@suse.cz>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6/route.c')
0 files changed, 0 insertions, 0 deletions