diff options
| author | Johannes Berg | 2010-06-10 10:21:42 +0200 |
|---|---|---|
| committer | John W. Linville | 2010-06-14 21:39:27 +0200 |
| commit | 0ab337032a0dfcd5f2527d3306d3deeba5f95b59 (patch) | |
| tree | 88795edc149fd88574fece0c8f23774ee8a9155c /net/mac80211/tx.c | |
| parent | mac80211: refcount aggregation queue stop (diff) | |
| download | kernel-qcow2-linux-0ab337032a0dfcd5f2527d3306d3deeba5f95b59.tar.gz kernel-qcow2-linux-0ab337032a0dfcd5f2527d3306d3deeba5f95b59.tar.xz kernel-qcow2-linux-0ab337032a0dfcd5f2527d3306d3deeba5f95b59.zip | |
mac80211: make TX aggregation start/stop request async
When the driver or rate control requests starting
or stopping an aggregation session, that currently
causes a direct callback into the driver, which
could potentially cause locking problems. Also,
the functions need to be callable from contexts
that cannot sleep, and thus will interfere with
making the ampdu_action callback sleeping.
To address these issues, add a new work item for
each station that will process any start or stop
requests out of line.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'net/mac80211/tx.c')
| -rw-r--r-- | net/mac80211/tx.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c index 7bf1f9c9ea34..698d4718b1a4 100644 --- a/net/mac80211/tx.c +++ b/net/mac80211/tx.c @@ -1102,6 +1102,11 @@ static bool ieee80211_tx_prep_agg(struct ieee80211_tx_data *tx, if (test_bit(HT_AGG_STATE_OPERATIONAL, &tid_tx->state)) { info->flags |= IEEE80211_TX_CTL_AMPDU; + } else if (test_bit(HT_AGG_STATE_WANT_START, &tid_tx->state)) { + /* + * nothing -- this aggregation session is being started + * but that might still fail with the driver + */ } else { spin_lock(&tx->sta->lock); /* |