diff options
| author | Taehee Yoo | 2017-03-27 17:28:50 +0200 |
|---|---|---|
| committer | Pablo Neira Ayuso | 2017-04-13 22:48:03 +0200 |
| commit | 5389023421b8f719fe4f1e6abd3f0bd0e571866e (patch) | |
| tree | de4f29f019e6d167174f437296b7ae9316fec29d /net/netfilter/nf_nat_core.c | |
| parent | netfilter: udplite: Remove duplicated udplite4/6 declaration (diff) | |
| download | kernel-qcow2-linux-5389023421b8f719fe4f1e6abd3f0bd0e571866e.tar.gz kernel-qcow2-linux-5389023421b8f719fe4f1e6abd3f0bd0e571866e.tar.xz kernel-qcow2-linux-5389023421b8f719fe4f1e6abd3f0bd0e571866e.zip | |
netfilter: nat: remove rcu_read_lock in __nf_nat_decode_session.
__nf_nat_decode_session is called from nf_nat_decode_session as decodefn.
before calling decodefn, it already set rcu_read_lock. so rcu_read_lock in
__nf_nat_decode_session can be removed.
Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'net/netfilter/nf_nat_core.c')
| -rw-r--r-- | net/netfilter/nf_nat_core.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/net/netfilter/nf_nat_core.c b/net/netfilter/nf_nat_core.c index 376c1b36f222..fb0e65411785 100644 --- a/net/netfilter/nf_nat_core.c +++ b/net/netfilter/nf_nat_core.c @@ -71,11 +71,10 @@ static void __nf_nat_decode_session(struct sk_buff *skb, struct flowi *fl) if (ct == NULL) return; - family = ct->tuplehash[IP_CT_DIR_ORIGINAL].tuple.src.l3num; - rcu_read_lock(); + family = nf_ct_l3num(ct); l3proto = __nf_nat_l3proto_find(family); if (l3proto == NULL) - goto out; + return; dir = CTINFO2DIR(ctinfo); if (dir == IP_CT_DIR_ORIGINAL) @@ -84,8 +83,6 @@ static void __nf_nat_decode_session(struct sk_buff *skb, struct flowi *fl) statusbit = IPS_SRC_NAT; l3proto->decode_session(skb, ct, dir, statusbit, fl); -out: - rcu_read_unlock(); } int nf_xfrm_me_harder(struct net *net, struct sk_buff *skb, unsigned int family) |