diff options
| author | Patrick McHardy | 2015-03-26 13:39:39 +0100 |
|---|---|---|
| committer | Pablo Neira Ayuso | 2015-04-01 11:17:29 +0200 |
| commit | 6908665826d56ddd024f3e131a9ee36f0d140943 (patch) | |
| tree | 723d477396da1b93c2657e2d35c50a538e411bae /net/netfilter/nf_tables_api.c | |
| parent | netfilter: nf_tables: add set garbage collection helpers (diff) | |
| download | kernel-qcow2-linux-6908665826d56ddd024f3e131a9ee36f0d140943.tar.gz kernel-qcow2-linux-6908665826d56ddd024f3e131a9ee36f0d140943.tar.xz kernel-qcow2-linux-6908665826d56ddd024f3e131a9ee36f0d140943.zip | |
netfilter: nf_tables: add GC synchronization helpers
GC is expected to happen asynchrously to the netlink interface. In the
netlink path, both insertion and removal of elements consist of two
steps, insertion followed by activation or deactivation followed by
removal, during which the element must not be freed by GC.
The synchronization helpers use an unused bit in the genmask field to
atomically mark an element as "busy", meaning it is either currently
being handled through the netlink API or by GC.
Elements being processed by GC will never survive, netlink will simply
ignore them. Elements being currently processed through netlink will be
skipped by GC and reprocessed during the next run.
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'net/netfilter/nf_tables_api.c')
| -rw-r--r-- | net/netfilter/nf_tables_api.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c index 138e47fddab7..3aa92b3f85fd 100644 --- a/net/netfilter/nf_tables_api.c +++ b/net/netfilter/nf_tables_api.c @@ -3338,7 +3338,7 @@ static int nft_add_set_elem(struct nft_ctx *ctx, struct nft_set *set, if (trans == NULL) goto err4; - ext->genmask = nft_genmask_cur(ctx->net); + ext->genmask = nft_genmask_cur(ctx->net) | NFT_SET_ELEM_BUSY_MASK; err = set->ops->insert(set, &elem); if (err < 0) goto err5; |