diff options
| author | Markus Elfring | 2014-11-18 20:37:05 +0100 |
|---|---|---|
| committer | Pablo Neira Ayuso | 2014-11-20 13:08:43 +0100 |
| commit | 982f405136a44754e884184d24b70d2d4cefcb7a (patch) | |
| tree | 859f3fc225ed106392df89500c2deac8de57326d /net/netfilter/nf_tables_api.c | |
| parent | netfilter: nf_conntrack_h323: lookup route from proper net namespace (diff) | |
| download | kernel-qcow2-linux-982f405136a44754e884184d24b70d2d4cefcb7a.tar.gz kernel-qcow2-linux-982f405136a44754e884184d24b70d2d4cefcb7a.tar.xz kernel-qcow2-linux-982f405136a44754e884184d24b70d2d4cefcb7a.zip | |
netfilter: Deletion of unnecessary checks before two function calls
The functions free_percpu() and module_put() test whether their argument
is NULL and then return immediately. Thus the test around the call is
not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Julian Anastasov <ja@ssi.bg>
Acked-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'net/netfilter/nf_tables_api.c')
| -rw-r--r-- | net/netfilter/nf_tables_api.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c index 1ffb253c6a77..18a9daef22dd 100644 --- a/net/netfilter/nf_tables_api.c +++ b/net/netfilter/nf_tables_api.c @@ -3674,8 +3674,7 @@ static int nf_tables_abort(struct sk_buff *skb) break; case NFT_MSG_NEWCHAIN: if (nft_trans_chain_update(trans)) { - if (nft_trans_chain_stats(trans)) - free_percpu(nft_trans_chain_stats(trans)); + free_percpu(nft_trans_chain_stats(trans)); nft_trans_destroy(trans); } else { |