summaryrefslogtreecommitdiffstats
path: root/net/netfilter/nfnetlink_queue_core.c
diff options
context:
space:
mode:
authorWei Yongjun2012-08-28 05:14:15 +0200
committerPablo Neira Ayuso2012-09-09 20:33:57 +0200
commita67299556ea1aa56daaeb985fd32295dacecba1a (patch)
tree55656c070c8b8e854474e7e4e9093cfdbd2e722e /net/netfilter/nfnetlink_queue_core.c
parentnetfilter: nf_nat: fix out-of-bounds access in address selection (diff)
downloadkernel-qcow2-linux-a67299556ea1aa56daaeb985fd32295dacecba1a.tar.gz
kernel-qcow2-linux-a67299556ea1aa56daaeb985fd32295dacecba1a.tar.xz
kernel-qcow2-linux-a67299556ea1aa56daaeb985fd32295dacecba1a.zip
netfilter: nfnetlink_queue: remove pointless conditional before kfree_skb()
Remove pointless conditional before kfree_skb(). Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'net/netfilter/nfnetlink_queue_core.c')
-rw-r--r--net/netfilter/nfnetlink_queue_core.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/net/netfilter/nfnetlink_queue_core.c b/net/netfilter/nfnetlink_queue_core.c
index c0496a55ad0c..5c2d78d3a4d8 100644
--- a/net/netfilter/nfnetlink_queue_core.c
+++ b/net/netfilter/nfnetlink_queue_core.c
@@ -406,8 +406,7 @@ nfqnl_build_packet_message(struct nfqnl_instance *queue,
return skb;
nla_put_failure:
- if (skb)
- kfree_skb(skb);
+ kfree_skb(skb);
net_err_ratelimited("nf_queue: error creating packet message\n");
return NULL;
}