diff options
| author | Johannes Berg | 2013-11-19 15:19:39 +0100 |
|---|---|---|
| committer | David S. Miller | 2013-11-19 22:39:06 +0100 |
| commit | 2a94fe48f32ccf7321450a2cc07f2b724a444e5b (patch) | |
| tree | e5a066d8f83d8822d448421019a4503f361295f9 /net/openvswitch/dp_notify.c | |
| parent | genetlink: pass family to functions using groups (diff) | |
| download | kernel-qcow2-linux-2a94fe48f32ccf7321450a2cc07f2b724a444e5b.tar.gz kernel-qcow2-linux-2a94fe48f32ccf7321450a2cc07f2b724a444e5b.tar.xz kernel-qcow2-linux-2a94fe48f32ccf7321450a2cc07f2b724a444e5b.zip | |
genetlink: make multicast groups const, prevent abuse
Register generic netlink multicast groups as an array with
the family and give them contiguous group IDs. Then instead
of passing the global group ID to the various functions that
send messages, pass the ID relative to the family - for most
families that's just 0 because the only have one group.
This avoids the list_head and ID in each group, adding a new
field for the mcast group ID offset to the family.
At the same time, this allows us to prevent abusing groups
again like the quota and dropmon code did, since we can now
check that a family only uses a group it owns.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/openvswitch/dp_notify.c')
| -rw-r--r-- | net/openvswitch/dp_notify.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/net/openvswitch/dp_notify.c b/net/openvswitch/dp_notify.c index f4b66c84ea0b..2c631fe76be1 100644 --- a/net/openvswitch/dp_notify.c +++ b/net/openvswitch/dp_notify.c @@ -35,15 +35,13 @@ static void dp_detach_port_notify(struct vport *vport) ovs_dp_detach_port(vport); if (IS_ERR(notify)) { genl_set_err(&dp_vport_genl_family, ovs_dp_get_net(dp), 0, - ovs_dp_vport_multicast_group.id, - PTR_ERR(notify)); + 0, PTR_ERR(notify)); return; } genlmsg_multicast_netns(&dp_vport_genl_family, ovs_dp_get_net(dp), notify, 0, - ovs_dp_vport_multicast_group.id, - GFP_KERNEL); + 0, GFP_KERNEL); } void ovs_dp_notify_wq(struct work_struct *work) |