diff options
| author | Reshetova, Elena | 2017-07-04 14:53:15 +0200 |
|---|---|---|
| committer | David S. Miller | 2017-07-04 23:35:17 +0200 |
| commit | 50d61ff789d728a9b6624582ce28441dc0bf5b42 (patch) | |
| tree | ba696c03f20de2bdac89ee3e3c08a04dab587e24 /net/rds/ib_rdma.c | |
| parent | net, sunrpc: convert gss_upcall_msg.count from atomic_t to refcount_t (diff) | |
| download | kernel-qcow2-linux-50d61ff789d728a9b6624582ce28441dc0bf5b42.tar.gz kernel-qcow2-linux-50d61ff789d728a9b6624582ce28441dc0bf5b42.tar.xz kernel-qcow2-linux-50d61ff789d728a9b6624582ce28441dc0bf5b42.zip | |
net, rds: convert rds_ib_device.refcount from atomic_t to refcount_t
refcount_t type and corresponding API should be
used instead of atomic_t when the variable is used as
a reference counter. This allows to avoid accidental
refcounter overflows that might lead to use-after-free
situations.
Signed-off-by: Elena Reshetova <elena.reshetova@intel.com>
Signed-off-by: Hans Liljestrand <ishkamiel@gmail.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: David Windsor <dwindsor@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/rds/ib_rdma.c')
| -rw-r--r-- | net/rds/ib_rdma.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/rds/ib_rdma.c b/net/rds/ib_rdma.c index 977f69886c00..9a3c54e659e9 100644 --- a/net/rds/ib_rdma.c +++ b/net/rds/ib_rdma.c @@ -52,7 +52,7 @@ static struct rds_ib_device *rds_ib_get_device(__be32 ipaddr) list_for_each_entry_rcu(rds_ibdev, &rds_ib_devices, list) { list_for_each_entry_rcu(i_ipaddr, &rds_ibdev->ipaddr_list, list) { if (i_ipaddr->ipaddr == ipaddr) { - atomic_inc(&rds_ibdev->refcount); + refcount_inc(&rds_ibdev->refcount); rcu_read_unlock(); return rds_ibdev; } @@ -134,7 +134,7 @@ void rds_ib_add_conn(struct rds_ib_device *rds_ibdev, struct rds_connection *con spin_unlock_irq(&ib_nodev_conns_lock); ic->rds_ibdev = rds_ibdev; - atomic_inc(&rds_ibdev->refcount); + refcount_inc(&rds_ibdev->refcount); } void rds_ib_remove_conn(struct rds_ib_device *rds_ibdev, struct rds_connection *conn) |