diff options
| author | David Howells | 2018-03-30 22:05:44 +0200 |
|---|---|---|
| committer | David Howells | 2018-03-30 22:05:44 +0200 |
| commit | 17226f1240381812c3a4927dc9da2814fb71c8ac (patch) | |
| tree | 49ef90fafb4ae55ff13e0c373a81bbc509718bd8 /net/rxrpc/ar-internal.h | |
| parent | rxrpc: Add a tracepoint to track rxrpc_peer refcounting (diff) | |
| download | kernel-qcow2-linux-17226f1240381812c3a4927dc9da2814fb71c8ac.tar.gz kernel-qcow2-linux-17226f1240381812c3a4927dc9da2814fb71c8ac.tar.xz kernel-qcow2-linux-17226f1240381812c3a4927dc9da2814fb71c8ac.zip | |
rxrpc: Fix leak of rxrpc_peer objects
When a new client call is requested, an rxrpc_conn_parameters struct object
is passed in with a bunch of parameters set, such as the local endpoint to
use. A pointer to the target peer record is also placed in there by
rxrpc_get_client_conn() - and this is removed if and only if a new
connection object is allocated. Thus it leaks if a new connection object
isn't allocated.
Fix this by putting any peer object attached to the rxrpc_conn_parameters
object in the function that allocated it.
Fixes: 19ffa01c9c45 ("rxrpc: Use structs to hold connection params and protocol info")
Signed-off-by: David Howells <dhowells@redhat.com>
Diffstat (limited to 'net/rxrpc/ar-internal.h')
| -rw-r--r-- | net/rxrpc/ar-internal.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/rxrpc/ar-internal.h b/net/rxrpc/ar-internal.h index c46583bc255d..90d7079e0aa9 100644 --- a/net/rxrpc/ar-internal.h +++ b/net/rxrpc/ar-internal.h @@ -1041,6 +1041,7 @@ struct rxrpc_peer *rxrpc_lookup_peer(struct rxrpc_local *, struct rxrpc_peer *rxrpc_alloc_peer(struct rxrpc_local *, gfp_t); struct rxrpc_peer *rxrpc_lookup_incoming_peer(struct rxrpc_local *, struct rxrpc_peer *); +void rxrpc_destroy_all_peers(struct rxrpc_net *); struct rxrpc_peer *rxrpc_get_peer(struct rxrpc_peer *); struct rxrpc_peer *rxrpc_get_peer_maybe(struct rxrpc_peer *); void rxrpc_put_peer(struct rxrpc_peer *); |