diff options
| author | Eric W. Biederman | 2013-02-02 01:39:32 +0100 |
|---|---|---|
| committer | Eric W. Biederman | 2013-02-13 15:15:17 +0100 |
| commit | 0b4d51b02a2e941beec6f02a6c7a32c5a28c5b43 (patch) | |
| tree | d25f90f6dbaf133865f9761b80e8a7324a5888f8 /net/sunrpc/auth_gss/auth_gss.c | |
| parent | sunrpc: Use kuid_t and kgid_t where appropriate (diff) | |
| download | kernel-qcow2-linux-0b4d51b02a2e941beec6f02a6c7a32c5a28c5b43.tar.gz kernel-qcow2-linux-0b4d51b02a2e941beec6f02a6c7a32c5a28c5b43.tar.xz kernel-qcow2-linux-0b4d51b02a2e941beec6f02a6c7a32c5a28c5b43.zip | |
sunrpc: Use uid_eq and gid_eq where appropriate
When comparing uids use uid_eq instead of ==.
When comparing gids use gid_eq instead of ==.
And unfortunate cost of type safety.
Cc: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Diffstat (limited to 'net/sunrpc/auth_gss/auth_gss.c')
| -rw-r--r-- | net/sunrpc/auth_gss/auth_gss.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c index 4daab81ca337..1b8b3e4fad46 100644 --- a/net/sunrpc/auth_gss/auth_gss.c +++ b/net/sunrpc/auth_gss/auth_gss.c @@ -307,7 +307,7 @@ __gss_find_upcall(struct rpc_pipe *pipe, kuid_t uid) { struct gss_upcall_msg *pos; list_for_each_entry(pos, &pipe->in_downcall, list) { - if (pos->uid != uid) + if (!uid_eq(pos->uid, uid)) continue; atomic_inc(&pos->count); dprintk("RPC: %s found msg %p\n", __func__, pos); @@ -1115,7 +1115,7 @@ out: } if (gss_cred->gc_principal != NULL) return 0; - return rc->cr_uid == acred->uid; + return uid_eq(rc->cr_uid, acred->uid); } /* |