diff options
| author | Bryan Schumaker | 2011-04-13 20:31:28 +0200 |
|---|---|---|
| committer | Trond Myklebust | 2011-04-13 21:12:22 +0200 |
| commit | d1a8016a2d1e75021ecc8715e3c81442d7218eb6 (patch) | |
| tree | b2aaef4f3aa4566765c6e3c743c74929a7790af2 /net/sunrpc/auth_gss | |
| parent | Don't mark_inode_dirty_sync() while holding lock (diff) | |
| download | kernel-qcow2-linux-d1a8016a2d1e75021ecc8715e3c81442d7218eb6.tar.gz kernel-qcow2-linux-d1a8016a2d1e75021ecc8715e3c81442d7218eb6.tar.xz kernel-qcow2-linux-d1a8016a2d1e75021ecc8715e3c81442d7218eb6.zip | |
NFS: Fix infinite loop in gss_create_upcall()
There can be an infinite loop if gss_create_upcall() is called without
the userspace program running. To prevent this, we return -EACCES if
we notice that pipe_version hasn't changed (indicating that the pipe
has not been opened).
Signed-off-by: Bryan Schumaker <bjschuma@netapp.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Diffstat (limited to 'net/sunrpc/auth_gss')
| -rw-r--r-- | net/sunrpc/auth_gss/auth_gss.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c index f3914d0c5079..339ba64cce1e 100644 --- a/net/sunrpc/auth_gss/auth_gss.c +++ b/net/sunrpc/auth_gss/auth_gss.c @@ -520,7 +520,7 @@ gss_refresh_upcall(struct rpc_task *task) warn_gssd(); task->tk_timeout = 15*HZ; rpc_sleep_on(&pipe_version_rpc_waitqueue, task, NULL); - return 0; + return -EAGAIN; } if (IS_ERR(gss_msg)) { err = PTR_ERR(gss_msg); @@ -563,10 +563,12 @@ retry: if (PTR_ERR(gss_msg) == -EAGAIN) { err = wait_event_interruptible_timeout(pipe_version_waitqueue, pipe_version >= 0, 15*HZ); + if (pipe_version < 0) { + warn_gssd(); + err = -EACCES; + } if (err) goto out; - if (pipe_version < 0) - warn_gssd(); goto retry; } if (IS_ERR(gss_msg)) { |