summaryrefslogtreecommitdiffstats
path: root/net/sunrpc/svc_xprt.c
diff options
context:
space:
mode:
authorTrond Myklebust2014-05-18 20:05:22 +0200
committerJ. Bruce Fields2014-05-22 21:57:22 +0200
commitc789102c20bbbdda6831a273e046715be9d6af79 (patch)
treedf7f2e7d6254ea61c17b48650e38246f2b1ccac0 /net/sunrpc/svc_xprt.c
parentNFSD: Ignore client's source port on RDMA transports (diff)
downloadkernel-qcow2-linux-c789102c20bbbdda6831a273e046715be9d6af79.tar.gz
kernel-qcow2-linux-c789102c20bbbdda6831a273e046715be9d6af79.tar.xz
kernel-qcow2-linux-c789102c20bbbdda6831a273e046715be9d6af79.zip
SUNRPC: Fix a module reference leak in svc_handle_xprt
If the accept() call fails, we need to put the module reference. Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com> Cc: stable@vger.kernel.org Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'net/sunrpc/svc_xprt.c')
-rw-r--r--net/sunrpc/svc_xprt.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c
index 614956f1777e..29772e01b179 100644
--- a/net/sunrpc/svc_xprt.c
+++ b/net/sunrpc/svc_xprt.c
@@ -730,6 +730,8 @@ static int svc_handle_xprt(struct svc_rqst *rqstp, struct svc_xprt *xprt)
newxpt = xprt->xpt_ops->xpo_accept(xprt);
if (newxpt)
svc_add_new_temp_xprt(serv, newxpt);
+ else
+ module_put(xprt->xpt_class->xcl_owner);
} else if (xprt->xpt_ops->xpo_has_wspace(xprt)) {
/* XPT_DATA|XPT_DEFERRED case: */
dprintk("svc: server %p, pool %u, transport %p, inuse=%d\n",