diff options
| author | Chuck Lever | 2019-06-19 16:32:38 +0200 |
|---|---|---|
| committer | Anna Schumaker | 2019-07-02 22:29:21 +0200 |
| commit | 2d0abe36cf13fb7b577949fd1539326adddcc9bc (patch) | |
| tree | 96c99216ecec578b13c1bc2e388d47c0b36576d4 /net/sunrpc | |
| parent | xprtrdma: Fix a BUG when tracing is enabled with NFSv4.1 on RDMA (diff) | |
| download | kernel-qcow2-linux-2d0abe36cf13fb7b577949fd1539326adddcc9bc.tar.gz kernel-qcow2-linux-2d0abe36cf13fb7b577949fd1539326adddcc9bc.tar.xz kernel-qcow2-linux-2d0abe36cf13fb7b577949fd1539326adddcc9bc.zip | |
xprtrdma: Fix use-after-free in rpcrdma_post_recvs
Dereference wr->next /before/ the memory backing wr has been
released. This issue was found by code inspection. It is not
expected to be a significant problem because it is in an error
path that is almost never executed.
Fixes: 7c8d9e7c8863 ("xprtrdma: Move Receive posting to ... ")
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Diffstat (limited to 'net/sunrpc')
| -rw-r--r-- | net/sunrpc/xprtrdma/verbs.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c index 84bb37924540..e71315e9dca2 100644 --- a/net/sunrpc/xprtrdma/verbs.c +++ b/net/sunrpc/xprtrdma/verbs.c @@ -1553,10 +1553,11 @@ rpcrdma_post_recvs(struct rpcrdma_xprt *r_xprt, bool temp) rc = ib_post_recv(r_xprt->rx_ia.ri_id->qp, wr, (const struct ib_recv_wr **)&bad_wr); if (rc) { - for (wr = bad_wr; wr; wr = wr->next) { + for (wr = bad_wr; wr;) { struct rpcrdma_rep *rep; rep = container_of(wr, struct rpcrdma_rep, rr_recv_wr); + wr = wr->next; rpcrdma_recv_buffer_put(rep); --count; } |