diff options
| author | Johannes Berg | 2013-11-19 15:19:31 +0100 |
|---|---|---|
| committer | David S. Miller | 2013-11-19 22:39:05 +0100 |
| commit | c53ed7423619b4e8108914a9f31b426dd58ad591 (patch) | |
| tree | 03a469a7f00d99ff73bf947b5306369bfaff18f5 /net/tipc/netlink.c | |
| parent | tcp: don't update snd_nxt, when a socket is switched from repair mode (diff) | |
| download | kernel-qcow2-linux-c53ed7423619b4e8108914a9f31b426dd58ad591.tar.gz kernel-qcow2-linux-c53ed7423619b4e8108914a9f31b426dd58ad591.tar.xz kernel-qcow2-linux-c53ed7423619b4e8108914a9f31b426dd58ad591.zip | |
genetlink: only pass array to genl_register_family_with_ops()
As suggested by David Miller, make genl_register_family_with_ops()
a macro and pass only the array, evaluating ARRAY_SIZE() in the
macro, this is a little safer.
The openvswitch has some indirection, assing ops/n_ops directly in
that code. This might ultimately just assign the pointers in the
family initializations, saving the struct genl_family_and_ops and
code (once mcast groups are handled differently.)
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/tipc/netlink.c')
| -rw-r--r-- | net/tipc/netlink.c | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/net/tipc/netlink.c b/net/tipc/netlink.c index 8bcd4985d0fb..9f72a6376362 100644 --- a/net/tipc/netlink.c +++ b/net/tipc/netlink.c @@ -76,9 +76,11 @@ static struct genl_family tipc_genl_family = { .maxattr = 0, }; -static struct genl_ops tipc_genl_ops = { - .cmd = TIPC_GENL_CMD, - .doit = handle_cmd, +static struct genl_ops tipc_genl_ops[] = { + { + .cmd = TIPC_GENL_CMD, + .doit = handle_cmd, + }, }; static int tipc_genl_family_registered; @@ -87,8 +89,7 @@ int tipc_netlink_start(void) { int res; - res = genl_register_family_with_ops(&tipc_genl_family, - &tipc_genl_ops, 1); + res = genl_register_family_with_ops(&tipc_genl_family, tipc_genl_ops); if (res) { pr_err("Failed to register netlink interface\n"); return res; |