diff options
| author | Saeed Mahameed | 2017-10-31 23:34:00 +0100 |
|---|---|---|
| committer | Saeed Mahameed | 2017-11-10 07:39:20 +0100 |
| commit | 2a8d6065e7b90ad9d5540650944d802b0f86bdfe (patch) | |
| tree | 1986cbf86d179ac840942b2baad28333f76b463c /net/tipc | |
| parent | net/mlx5: Cancel health poll before sending panic teardown command (diff) | |
| download | kernel-qcow2-linux-2a8d6065e7b90ad9d5540650944d802b0f86bdfe.tar.gz kernel-qcow2-linux-2a8d6065e7b90ad9d5540650944d802b0f86bdfe.tar.xz kernel-qcow2-linux-2a8d6065e7b90ad9d5540650944d802b0f86bdfe.zip | |
net/mlx5e: Fix napi poll with zero budget
napi->poll can be called with budget 0, e.g. in netpoll scenarios
where the caller only wants to poll TX rings
(poll_one_napi@net/core/netpoll.c).
The below commit changed RX polling from "while" loop to "do {} while",
which caused to ignore the initial budget and handle at least one RX
packet.
This fixes the following warning:
[ 2852.049194] mlx5e_napi_poll+0x0/0x260 [mlx5_core] exceeded budget in poll
[ 2852.049195] ------------[ cut here ]------------
[ 2852.049195] WARNING: CPU: 0 PID: 25691 at net/core/netpoll.c:171 netpoll_poll_dev+0x18a/0x1a0
Fixes: 4b7dfc992514 ("net/mlx5e: Early-return on empty completion queues")
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
Reported-by: Martin KaFai Lau <kafai@fb.com>
Tested-by: Martin KaFai Lau <kafai@fb.com>
Cc: kernel-team@fb.com
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
Diffstat (limited to 'net/tipc')
0 files changed, 0 insertions, 0 deletions