diff options
| author | Jason Wang | 2019-05-09 05:20:18 +0200 |
|---|---|---|
| committer | David S. Miller | 2019-05-09 18:21:42 +0200 |
| commit | 9871a9e47a2646fe30ae7fd2e67668a8d30912f6 (patch) | |
| tree | 06772218a11b4c05b06d31ed92c649cac61b6a8b /net/tipc | |
| parent | tuntap: fix dividing by zero in ebpf queue selection (diff) | |
| download | kernel-qcow2-linux-9871a9e47a2646fe30ae7fd2e67668a8d30912f6.tar.gz kernel-qcow2-linux-9871a9e47a2646fe30ae7fd2e67668a8d30912f6.tar.xz kernel-qcow2-linux-9871a9e47a2646fe30ae7fd2e67668a8d30912f6.zip | |
tuntap: synchronize through tfiles array instead of tun->numqueues
When a queue(tfile) is detached through __tun_detach(), we move the
last enabled tfile to the position where detached one sit but don't
NULL out last position. We expect to synchronize the datapath through
tun->numqueues. Unfortunately, this won't work since we're lacking
sufficient mechanism to order or synchronize the access to
tun->numqueues.
To fix this, NULL out the last position during detaching and check
RCU protected tfile against NULL instead of checking tun->numqueues in
datapath.
Cc: YueHaibing <yuehaibing@huawei.com>
Cc: Cong Wang <xiyou.wangcong@gmail.com>
Cc: weiyongjun (A) <weiyongjun1@huawei.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Fixes: c8d68e6be1c3b ("tuntap: multiqueue support")
Signed-off-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/tipc')
0 files changed, 0 insertions, 0 deletions