diff options
| author | Jakub Kicinski | 2019-06-04 00:17:00 +0200 |
|---|---|---|
| committer | David S. Miller | 2019-06-04 23:33:50 +0200 |
| commit | 87b11e0638c3dbf029a7c9020f8a779062db58fc (patch) | |
| tree | f57c4b71396f007c1e9436414595ef78912015db /net/tls | |
| parent | net/tls: check return values from skb_copy_bits() and skb_store_bits() (diff) | |
| download | kernel-qcow2-linux-87b11e0638c3dbf029a7c9020f8a779062db58fc.tar.gz kernel-qcow2-linux-87b11e0638c3dbf029a7c9020f8a779062db58fc.tar.xz kernel-qcow2-linux-87b11e0638c3dbf029a7c9020f8a779062db58fc.zip | |
net/tls: remove false positive warning
It's possible that TCP stack will decide to retransmit a packet
right when that packet's data gets acked, especially in presence
of packet reordering. This means that packets may be in flight,
even though tls_device code has already freed their record state.
Make fill_sg_in() and in turn tls_sw_fallback() not generate a
warning in that case, and quietly proceed to drop such frames.
Make the exit path from tls_sw_fallback() drop monitor friendly,
for users to be able to troubleshoot dropped retransmissions.
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Dirk van der Merwe <dirk.vandermerwe@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/tls')
| -rw-r--r-- | net/tls/tls_device_fallback.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/net/tls/tls_device_fallback.c b/net/tls/tls_device_fallback.c index c3a5fe624b4e..5a087e1981c3 100644 --- a/net/tls/tls_device_fallback.c +++ b/net/tls/tls_device_fallback.c @@ -240,7 +240,6 @@ static int fill_sg_in(struct scatterlist *sg_in, record = tls_get_record(ctx, tcp_seq, rcd_sn); if (!record) { spin_unlock_irqrestore(&ctx->lock, flags); - WARN(1, "Record not found for seq %u\n", tcp_seq); return -EINVAL; } @@ -409,7 +408,10 @@ put_sg: put_page(sg_page(&sg_in[--resync_sgs])); kfree(sg_in); free_orig: - kfree_skb(skb); + if (nskb) + consume_skb(skb); + else + kfree_skb(skb); return nskb; } |