summaryrefslogtreecommitdiffstats
path: root/net/tls
diff options
context:
space:
mode:
authorVladimir Oltean2019-06-03 01:31:37 +0200
committerDavid S. Miller2019-06-04 20:51:57 +0200
commitf4cfcfbdf03cf7cf5f9097803415dfdcf965676c (patch)
treed64a633cfef6f591fbe5d796e528951e05f3699a /net/tls
parentnet: phylink: avoid reducing support mask (diff)
downloadkernel-qcow2-linux-f4cfcfbdf03cf7cf5f9097803415dfdcf965676c.tar.gz
kernel-qcow2-linux-f4cfcfbdf03cf7cf5f9097803415dfdcf965676c.tar.xz
kernel-qcow2-linux-f4cfcfbdf03cf7cf5f9097803415dfdcf965676c.zip
net: dsa: sja1105: Fix link speed not working at 100 Mbps and below
The hardware values for link speed are held in the sja1105_speed_t enum. However they do not increase in the order that sja1105_get_speed_cfg was iterating over them (basically from SJA1105_SPEED_AUTO - 0 - to SJA1105_SPEED_1000MBPS - 1 - skipping the other two). Another bug is that the code in sja1105_adjust_port_config relies on the fact that an invalid link speed is detected by sja1105_get_speed_cfg and returned as -EINVAL. However storing this into an enum that only has positive members will cast it into an unsigned value, and it will miss the negative check. So take the simplest approach and remove the sja1105_get_speed_cfg function and replace it with a simple switch-case statement. Fixes: 8aa9ebccae87 ("net: dsa: Introduce driver for NXP SJA1105 5-port L2 switch") Signed-off-by: Vladimir Oltean <olteanv@gmail.com> Suggested-by: Andrew Lunn <andrew@lunn.ch> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/tls')
0 files changed, 0 insertions, 0 deletions