summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorXin Long2019-08-12 14:49:12 +0200
committerJakub Kicinski2019-08-14 04:08:20 +0200
commita1794de8b92ea6bc2037f445b296814ac826693e (patch)
treeff3178d4f8cc75cedd6fd51e2f4e7c18e960e83a /net
parentnet: phy: at803x: stop switching phy delay config needlessly (diff)
downloadkernel-qcow2-linux-a1794de8b92ea6bc2037f445b296814ac826693e.tar.gz
kernel-qcow2-linux-a1794de8b92ea6bc2037f445b296814ac826693e.tar.xz
kernel-qcow2-linux-a1794de8b92ea6bc2037f445b296814ac826693e.zip
sctp: fix the transport error_count check
As the annotation says in sctp_do_8_2_transport_strike(): "If the transport error count is greater than the pf_retrans threshold, and less than pathmaxrtx ..." It should be transport->error_count checked with pathmaxrxt, instead of asoc->pf_retrans. Fixes: 5aa93bcf66f4 ("sctp: Implement quick failover draft from tsvwg") Signed-off-by: Xin Long <lucien.xin@gmail.com> Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Diffstat (limited to 'net')
-rw-r--r--net/sctp/sm_sideeffect.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c
index a554d6d15d1b..1cf5bb5b73c4 100644
--- a/net/sctp/sm_sideeffect.c
+++ b/net/sctp/sm_sideeffect.c
@@ -546,7 +546,7 @@ static void sctp_do_8_2_transport_strike(struct sctp_cmd_seq *commands,
*/
if (net->sctp.pf_enable &&
(transport->state == SCTP_ACTIVE) &&
- (asoc->pf_retrans < transport->pathmaxrxt) &&
+ (transport->error_count < transport->pathmaxrxt) &&
(transport->error_count > asoc->pf_retrans)) {
sctp_assoc_control_transport(asoc, transport,