diff options
| author | Fabio Estevam | 2014-12-11 00:51:40 +0100 |
|---|---|---|
| committer | Linus Torvalds | 2014-12-11 02:41:11 +0100 |
| commit | 15160f90b8640b7d83ec8cdac64c65403355faa6 (patch) | |
| tree | 43eec7a6f315dffd884646812caf55713430b1a1 /scripts/checkpatch.pl | |
| parent | checkpatch: improve test for no space after cast (diff) | |
| download | kernel-qcow2-linux-15160f90b8640b7d83ec8cdac64c65403355faa6.tar.gz kernel-qcow2-linux-15160f90b8640b7d83ec8cdac64c65403355faa6.tar.xz kernel-qcow2-linux-15160f90b8640b7d83ec8cdac64c65403355faa6.zip | |
checkpatch: improve warning message for "needless if" case
Add an 'and' to the sentence so that it looks better:
WARNING: debugfs_remove(NULL) is safe and this check is probably not required
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'scripts/checkpatch.pl')
| -rwxr-xr-x | scripts/checkpatch.pl | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index d94f5d879fb1..10ad5ab571dc 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -4446,7 +4446,7 @@ sub process { my $expr = '\s*\(\s*' . quotemeta($1) . '\s*\)\s*;'; if ($line =~ /\b(kfree|usb_free_urb|debugfs_remove(?:_recursive)?)$expr/) { WARN('NEEDLESS_IF', - "$1(NULL) is safe this check is probably not required\n" . $hereprev); + "$1(NULL) is safe and this check is probably not required\n" . $hereprev); } } |