diff options
| author | Andy Whitcroft | 2010-10-26 23:23:13 +0200 |
|---|---|---|
| committer | Linus Torvalds | 2010-10-27 01:52:20 +0200 |
| commit | 9446ef569c288e683225fec8337a0b2b81e75cc5 (patch) | |
| tree | a46d6265a77f637f882c9136c914483b5d4598d8 /scripts/checkpatch.pl | |
| parent | checkpatch: ensure we do not collapse bracketed sections into constants (diff) | |
| download | kernel-qcow2-linux-9446ef569c288e683225fec8337a0b2b81e75cc5.tar.gz kernel-qcow2-linux-9446ef569c288e683225fec8337a0b2b81e75cc5.tar.xz kernel-qcow2-linux-9446ef569c288e683225fec8337a0b2b81e75cc5.zip | |
checkpatch: handle casts better fixing false categorisation of : as binary
The following incantation is triggering categorisation of its colon (:) as
a binary form, which it is not:
return foo ? (s8)bar : baz;
Handle casts differently from types in the categoriser, allowing us to
better track (s8)bar as a value and not a declaration.
Reported-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Andy Whitcroft <apw@canonical.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'scripts/checkpatch.pl')
| -rwxr-xr-x | scripts/checkpatch.pl | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 8d010ac0efe1..3cec2990d51e 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -845,6 +845,11 @@ sub annotate_values { $av_preprocessor = 0; } + } elsif ($cur =~ /^(\(\s*$Type\s*)\)/) { + print "CAST($1)\n" if ($dbg_values > 1); + push(@av_paren_type, $type); + $type = 'C'; + } elsif ($cur =~ /^($Type)\s*(?:$Ident|,|\)|\(|\s*$)/) { print "DECLARE($1)\n" if ($dbg_values > 1); $type = 'T'; |