diff options
| author | Michael Forney | 2018-02-07 07:41:17 +0100 |
|---|---|---|
| committer | Masahiro Yamada | 2018-03-25 19:01:18 +0200 |
| commit | 1fe7d2bb24d7db6175e0b0a31d8fe03dc6ffb16e (patch) | |
| tree | 1d1acfa6039c3f4a51ea7032656d09f58bf14654 /scripts/gen_initramfs_list.sh | |
| parent | kbuild: add clang-version.sh (diff) | |
| download | kernel-qcow2-linux-1fe7d2bb24d7db6175e0b0a31d8fe03dc6ffb16e.tar.gz kernel-qcow2-linux-1fe7d2bb24d7db6175e0b0a31d8fe03dc6ffb16e.tar.xz kernel-qcow2-linux-1fe7d2bb24d7db6175e0b0a31d8fe03dc6ffb16e.zip | |
kbuild: Improve portability of some sed invocations
* Use BREs where EREs aren't necessary.
* Pass -E instead of -r to use EREs. This will be standardized in the
next POSIX revision[0]. GNU sed supports this since 4.2 (May 2009),
and busybox since 1.22.0 (Jan 2014).
* Use the [:space:] character class instead of ` \t` in bracket
expressions. In bracket expressions, POSIX says that <backslash> loses
its special meaning, so a conforming implementation cannot expand \t
to <tab>[1].
* In BREs, use interval expressions (\{n,m\}) instead of non-standard
features like \+ and \?.
* Use a loop instead of -s flag.
There are still plenty of other cases of non-standard sed invocations
(use of ERE features in BREs, in-place editing), but this fixes some
core ones.
[0] http://austingroupbugs.net/view.php?id=528
[1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap09.html#tag_09_03_05
Signed-off-by: Michael Forney <forney@google.com>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Diffstat (limited to 'scripts/gen_initramfs_list.sh')
| -rwxr-xr-x | scripts/gen_initramfs_list.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/gen_initramfs_list.sh b/scripts/gen_initramfs_list.sh index 86a3c0e5cfbc..10e528b3a08f 100755 --- a/scripts/gen_initramfs_list.sh +++ b/scripts/gen_initramfs_list.sh @@ -194,7 +194,7 @@ input_file() { source="$1" if [ -f "$1" ]; then ${dep_list}header "$1" - is_cpio="$(echo "$1" | sed 's/^.*\.cpio\(\..*\)\?/cpio/')" + is_cpio="$(echo "$1" | sed 's/^.*\.cpio\(\..*\)\{0,1\}/cpio/')" if [ $2 -eq 0 -a ${is_cpio} = "cpio" ]; then cpio_file=$1 echo "$1" | grep -q '^.*\.cpio\..*' && is_cpio_compressed="compressed" |