summaryrefslogtreecommitdiffstats
path: root/scripts
diff options
context:
space:
mode:
authorMinwoo Im2019-06-02 05:43:39 +0200
committerSagi Grimberg2019-06-04 18:29:31 +0200
commit3562f5d9f21e7779ae442a45197fed6cb247fd22 (patch)
treeebab2e5a28dfcdd2e7659e82fe282e92e62b070d /scripts
parentnvme-tcp: fix queue mapping when queue count is limited (diff)
downloadkernel-qcow2-linux-3562f5d9f21e7779ae442a45197fed6cb247fd22.tar.gz
kernel-qcow2-linux-3562f5d9f21e7779ae442a45197fed6cb247fd22.tar.xz
kernel-qcow2-linux-3562f5d9f21e7779ae442a45197fed6cb247fd22.zip
nvmet: fix data_len to 0 for bdev-backed write_zeroes
The WRITE ZEROES command has no data transfer so that we need to initialize the struct (nvmet_req *req)->data_len to 0x0. While (nvmet_req *req)->transfer_len is initialized in nvmet_req_init(), data_len will be initialized by nowhere which might cause the failure with status code NVME_SC_SGL_INVALID_DATA | NVME_SC_DNR randomly. It's because nvmet_req_execute() checks like: if (unlikely(req->data_len != req->transfer_len)) { req->error_loc = offsetof(struct nvme_common_command, dptr); nvmet_req_complete(req, NVME_SC_SGL_INVALID_DATA | NVME_SC_DNR); } else req->execute(req); This patch fixes req->data_len not to be a randomly assigned by initializing it to 0x0 when preparing the command in nvmet_bdev_parse_io_cmd(). nvmet_file_parse_io_cmd() which is for file-backed I/O has already initialized the data_len field to 0x0, though. Cc: Christoph Hellwig <hch@lst.de> Cc: Sagi Grimberg <sagi@grimberg.me> Cc: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com> Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com> Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Diffstat (limited to 'scripts')
0 files changed, 0 insertions, 0 deletions