summaryrefslogtreecommitdiffstats
path: root/security/apparmor/capability.c
diff options
context:
space:
mode:
authorEric Paris2012-04-04 21:01:43 +0200
committerEric Paris2012-04-09 18:23:04 +0200
commit50c205f5e5c2e2af002fd4ef537ded79b90b1b56 (patch)
tree9965a7746aa8c5e982357d5b8c46850f3283206c /security/apparmor/capability.c
parentLSM: BUILD_BUG_ON if the common_audit_data union ever grows (diff)
downloadkernel-qcow2-linux-50c205f5e5c2e2af002fd4ef537ded79b90b1b56.tar.gz
kernel-qcow2-linux-50c205f5e5c2e2af002fd4ef537ded79b90b1b56.tar.xz
kernel-qcow2-linux-50c205f5e5c2e2af002fd4ef537ded79b90b1b56.zip
LSM: do not initialize common_audit_data to 0
It isn't needed. If you don't set the type of the data associated with that type it is a pretty obvious programming bug. So why waste the cycles? Signed-off-by: Eric Paris <eparis@redhat.com>
Diffstat (limited to 'security/apparmor/capability.c')
-rw-r--r--security/apparmor/capability.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/security/apparmor/capability.c b/security/apparmor/capability.c
index b66a0e4a5693..887a5e948945 100644
--- a/security/apparmor/capability.c
+++ b/security/apparmor/capability.c
@@ -65,7 +65,7 @@ static int audit_caps(struct aa_profile *profile, struct task_struct *task,
int type = AUDIT_APPARMOR_AUTO;
struct common_audit_data sa;
struct apparmor_audit_data aad = {0,};
- COMMON_AUDIT_DATA_INIT(&sa, LSM_AUDIT_DATA_CAP);
+ sa.type = LSM_AUDIT_DATA_CAP;
sa.aad = &aad;
sa.u.cap = cap;
sa.aad->tsk = task;