diff options
| author | Markus Elfring | 2014-11-03 14:54:36 +0100 |
|---|---|---|
| committer | Takashi Iwai | 2014-11-03 15:16:14 +0100 |
| commit | 31604d35db18c1382c7ee9fa836ff9ab0b4d2751 (patch) | |
| tree | f55e9f94fba3a32c6c29921f8242c4e3cbf7df2b /sound/pci/emu10k1/emufx.c | |
| parent | ALSA: echoaudio: remove all snd_printk (diff) | |
| download | kernel-qcow2-linux-31604d35db18c1382c7ee9fa836ff9ab0b4d2751.tar.gz kernel-qcow2-linux-31604d35db18c1382c7ee9fa836ff9ab0b4d2751.tar.xz kernel-qcow2-linux-31604d35db18c1382c7ee9fa836ff9ab0b4d2751.zip | |
ALSA: emu10k1: Deletion of unnecessary checks before three function calls
The functions kfree(), release_firmware() and snd_util_memhdr_free() test
whether their argument is NULL and then return immediately. Thus the test
around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/pci/emu10k1/emufx.c')
| -rw-r--r-- | sound/pci/emu10k1/emufx.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/sound/pci/emu10k1/emufx.c b/sound/pci/emu10k1/emufx.c index 745f0627c634..eb5c0aba41c1 100644 --- a/sound/pci/emu10k1/emufx.c +++ b/sound/pci/emu10k1/emufx.c @@ -777,8 +777,7 @@ static void snd_emu10k1_ctl_private_free(struct snd_kcontrol *kctl) kctl->private_value = 0; list_del(&ctl->list); kfree(ctl); - if (kctl->tlv.p) - kfree(kctl->tlv.p); + kfree(kctl->tlv.p); } static int snd_emu10k1_add_controls(struct snd_emu10k1 *emu, |