summaryrefslogtreecommitdiffstats
path: root/sound/soc/intel/skylake/skl-pcm.c
diff options
context:
space:
mode:
authorJeeja KP2015-10-27 01:22:45 +0100
committerMark Brown2015-11-16 11:08:09 +0100
commit4bd073f93f13ad5de8affb173056827117a4a930 (patch)
treeebefc635e1c5ee8f0a4aeca36649110a38a8dd8e /sound/soc/intel/skylake/skl-pcm.c
parentASoC: Intel: Skylake: Fix to correct check for non DSP widget (diff)
downloadkernel-qcow2-linux-4bd073f93f13ad5de8affb173056827117a4a930.tar.gz
kernel-qcow2-linux-4bd073f93f13ad5de8affb173056827117a4a930.tar.xz
kernel-qcow2-linux-4bd073f93f13ad5de8affb173056827117a4a930.zip
ASoC: Intel: Skylake: Fix not to ignore return value in be hw_params
Return value from skl_tplg_be_update_params() is ignored. But if the blob is null then the hw_params needs to return error. This patch fixes the issue by not ignoring return value from skl_tplg_be_update_params(). Signed-off-by: Jeeja KP <jeeja.kp@intel.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com> Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/intel/skylake/skl-pcm.c')
-rw-r--r--sound/soc/intel/skylake/skl-pcm.c7
1 files changed, 2 insertions, 5 deletions
diff --git a/sound/soc/intel/skylake/skl-pcm.c b/sound/soc/intel/skylake/skl-pcm.c
index a2f94ce1679d..1242beac4e46 100644
--- a/sound/soc/intel/skylake/skl-pcm.c
+++ b/sound/soc/intel/skylake/skl-pcm.c
@@ -291,9 +291,8 @@ static int skl_be_hw_params(struct snd_pcm_substream *substream,
p_params.ch = params_channels(params);
p_params.s_freq = params_rate(params);
p_params.stream = substream->stream;
- skl_tplg_be_update_params(dai, &p_params);
- return 0;
+ return skl_tplg_be_update_params(dai, &p_params);
}
static int skl_pcm_trigger(struct snd_pcm_substream *substream, int cmd,
@@ -352,9 +351,7 @@ static int skl_link_hw_params(struct snd_pcm_substream *substream,
p_params.stream = substream->stream;
p_params.link_dma_id = hdac_stream(link_dev)->stream_tag - 1;
- skl_tplg_be_update_params(dai, &p_params);
-
- return 0;
+ return skl_tplg_be_update_params(dai, &p_params);
}
static int skl_link_pcm_prepare(struct snd_pcm_substream *substream,