summaryrefslogtreecommitdiffstats
path: root/sound/soc/meson
diff options
context:
space:
mode:
authorJerome Brunet2019-06-13 13:42:32 +0200
committerMark Brown2019-06-13 20:44:02 +0200
commitcb36ff785e868992e96e8b9e5a0c2822b680a9e2 (patch)
tree6f200a265ced0f85d92055753437839078135d56 /sound/soc/meson
parentASoC: meson: axg-tdmout: right_j is not supported (diff)
downloadkernel-qcow2-linux-cb36ff785e868992e96e8b9e5a0c2822b680a9e2.tar.gz
kernel-qcow2-linux-cb36ff785e868992e96e8b9e5a0c2822b680a9e2.tar.xz
kernel-qcow2-linux-cb36ff785e868992e96e8b9e5a0c2822b680a9e2.zip
ASoC: meson: axg-tdm: fix sample clock inversion
The content of SND_SOC_DAIFMT_FORMAT_MASK is a number, not a bitfield, so the test to check if the format is i2s is wrong. Because of this the clock setting may be wrong. For example, the sample clock gets inverted in DSP B mode, when it should not. Fix the lrclk invert helper function Fixes: 1a11d88f499c ("ASoC: meson: add tdm formatter base driver") Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/meson')
-rw-r--r--sound/soc/meson/axg-tdm.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/meson/axg-tdm.h b/sound/soc/meson/axg-tdm.h
index e578b6f40a07..5774ce0916d4 100644
--- a/sound/soc/meson/axg-tdm.h
+++ b/sound/soc/meson/axg-tdm.h
@@ -40,7 +40,7 @@ struct axg_tdm_iface {
static inline bool axg_tdm_lrclk_invert(unsigned int fmt)
{
- return (fmt & SND_SOC_DAIFMT_I2S) ^
+ return ((fmt & SND_SOC_DAIFMT_FORMAT_MASK) == SND_SOC_DAIFMT_I2S) ^
!!(fmt & (SND_SOC_DAIFMT_IB_IF | SND_SOC_DAIFMT_NB_IF));
}