summaryrefslogtreecommitdiffstats
path: root/tools/bpf/bpftool/common.c
diff options
context:
space:
mode:
authorQuentin Monnet2018-12-14 14:56:01 +0100
committerDaniel Borkmann2018-12-15 01:31:49 +0100
commitc101189bc9680675a2686bafe908015a07a0da51 (patch)
tree65178d436002e69009993778078eb7c2e1a8940e /tools/bpf/bpftool/common.c
parenttools: bpftool: fix warning on struct bpf_prog_linfo definition (diff)
downloadkernel-qcow2-linux-c101189bc9680675a2686bafe908015a07a0da51.tar.gz
kernel-qcow2-linux-c101189bc9680675a2686bafe908015a07a0da51.tar.xz
kernel-qcow2-linux-c101189bc9680675a2686bafe908015a07a0da51.zip
tools: bpftool: fix -Wmissing declaration warnings
Help compiler check arguments for several utility functions used to print items to the console by adding the "printf" attribute when declaring those functions. Also, declare as "static" two functions that are only used in prog.c. All of them discovered by compiling bpftool with -Wmissing-format-attribute -Wmissing-declarations. Signed-off-by: Quentin Monnet <quentin.monnet@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Diffstat (limited to 'tools/bpf/bpftool/common.c')
-rw-r--r--tools/bpf/bpftool/common.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/bpf/bpftool/common.c b/tools/bpf/bpftool/common.c
index 99e4027dde75..24582e8a96fb 100644
--- a/tools/bpf/bpftool/common.c
+++ b/tools/bpf/bpftool/common.c
@@ -28,7 +28,7 @@
#define BPF_FS_MAGIC 0xcafe4a11
#endif
-void p_err(const char *fmt, ...)
+void __printf(1, 2) p_err(const char *fmt, ...)
{
va_list ap;
@@ -46,7 +46,7 @@ void p_err(const char *fmt, ...)
va_end(ap);
}
-void p_info(const char *fmt, ...)
+void __printf(1, 2) p_info(const char *fmt, ...)
{
va_list ap;