diff options
| author | Arnaldo Carvalho de Melo | 2019-05-20 16:04:08 +0200 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo | 2019-05-28 23:37:45 +0200 |
| commit | 2d45ef7033ec90104ae8e4c3996227bdad24dc76 (patch) | |
| tree | c9fceb085d7dc15bb06785cf998538b7d7c7d670 /tools/perf/builtin-top.c | |
| parent | perf python: Remove -fstack-protector-strong if clang doesn't have it (diff) | |
| download | kernel-qcow2-linux-2d45ef7033ec90104ae8e4c3996227bdad24dc76.tar.gz kernel-qcow2-linux-2d45ef7033ec90104ae8e4c3996227bdad24dc76.tar.xz kernel-qcow2-linux-2d45ef7033ec90104ae8e4c3996227bdad24dc76.zip | |
perf top: Lower message level for failure on synthesizing events for pre-existing BPF programs
Move it from being a pr_warning() to a pr_debug(). Also capitalize BPF
and explain what gets missing when we're not able to synthesize these
events: we'll not be able to resolve symbols, etc.
Reported-by: Ingo Molnar <mingo@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexei Starovoitov <ast@fb.com>
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Luis Cláudio Gonçalves <lclaudio@redhat.com>
Cc: Martin KaFai Lau <kafai@fb.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Song Liu <songliubraving@fb.com>
Cc: Wang Nan <wangnan0@huawei.com>
Cc: Yonghong Song <yhs@fb.com>
Link: https://lkml.kernel.org/n/tip-whpnfnw6xtd939odgt9bw9as@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/builtin-top.c')
| -rw-r--r-- | tools/perf/builtin-top.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index 31d78d874fc7..6651377fd762 100644 --- a/tools/perf/builtin-top.c +++ b/tools/perf/builtin-top.c @@ -1215,7 +1215,7 @@ static int __cmd_top(struct perf_top *top) &top->session->machines.host, &top->record_opts); if (ret < 0) - pr_warning("Couldn't synthesize bpf events.\n"); + pr_debug("Couldn't synthesize BPF events: Pre-existing BPF programs won't have symbols resolved.\n"); machine__synthesize_threads(&top->session->machines.host, &opts->target, top->evlist->threads, false, |