diff options
| author | Namhyung Kim | 2015-12-11 03:56:55 +0100 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo | 2015-12-11 12:36:18 +0100 |
| commit | 448f13b2d18fdc8dbaada97442e8954dcb4ef8fa (patch) | |
| tree | 47f760a1177626d9cdf9c1848f66c1909f80cbad /tools/perf/builtin-top.c | |
| parent | perf top: Access hists->lock only if needed (diff) | |
| download | kernel-qcow2-linux-448f13b2d18fdc8dbaada97442e8954dcb4ef8fa.tar.gz kernel-qcow2-linux-448f13b2d18fdc8dbaada97442e8954dcb4ef8fa.tar.xz kernel-qcow2-linux-448f13b2d18fdc8dbaada97442e8954dcb4ef8fa.zip | |
perf top: Fix annotation on --stdio
The ui__has_annotation() inside perf_top__record_precise_ip() should be
removed since it returns true only for TUI (and when sort key has
symbol). However the 'perf top --stdio' also supports annotation for a
symbol which was specified by 's' key action.
Actually it already does the necessary checks before calling the
function. So it's ok to get rid of the check here.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1449802616-16170-3-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/builtin-top.c')
| -rw-r--r-- | tools/perf/builtin-top.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index 586798acf7db..f447e5531f8b 100644 --- a/tools/perf/builtin-top.c +++ b/tools/perf/builtin-top.c @@ -189,8 +189,7 @@ static void perf_top__record_precise_ip(struct perf_top *top, if (pthread_mutex_trylock(¬es->lock)) return; - if (ui__has_annotation()) - err = hist_entry__inc_addr_samples(he, counter, ip); + err = hist_entry__inc_addr_samples(he, counter, ip); pthread_mutex_unlock(¬es->lock); |