diff options
| author | Jiri Olsa | 2018-11-19 11:12:01 +0100 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo | 2018-12-17 18:58:40 +0100 |
| commit | d8590430fb1e70132f1d330d6bbab7b943b35c3c (patch) | |
| tree | 15eb2c2d6a52f87647f2cb0a4a3d657b3ccf56d5 /tools/perf/builtin-top.c | |
| parent | perf top: Save and display the drop count stats (diff) | |
| download | kernel-qcow2-linux-d8590430fb1e70132f1d330d6bbab7b943b35c3c.tar.gz kernel-qcow2-linux-d8590430fb1e70132f1d330d6bbab7b943b35c3c.tar.xz kernel-qcow2-linux-d8590430fb1e70132f1d330d6bbab7b943b35c3c.zip | |
perf top: Display slow reader warning when droping samples
Currently we display the "Too slow to read ring buffer.." helpline only
in the slow reader thread. This patch triggers it also when the
processing thread drops samples, because it has the same reason, which
is too many data on input.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Acked-by: David S. Miller <davem@davemloft.net>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lkml.kernel.org/n/tip-bnev2mloavyurmgchcr3o24o@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/builtin-top.c')
| -rw-r--r-- | tools/perf/builtin-top.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index 9166f6087e3f..f22c531be366 100644 --- a/tools/perf/builtin-top.c +++ b/tools/perf/builtin-top.c @@ -571,7 +571,7 @@ static void perf_top__sort_new_samples(void *arg) hists__collapse_resort(hists, NULL); perf_evsel__output_resort(evsel, NULL); - if (t->lost) + if (t->lost || t->drop) pr_warning("Too slow to read ring buffer (change period (-c/-F) or limit CPUs (-C)\n"); perf_top__reset_sample_counters(t); |