diff options
| author | Kan Liang | 2016-03-30 21:16:15 +0200 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo | 2016-04-01 23:46:24 +0200 |
| commit | ac0e2cd555373ae6f8f3a3ad3fbbf5b6d1e7aaaa (patch) | |
| tree | acb9929531a5d0f051be6a662dff099f3ea8252e /tools/perf/util/pmu.c | |
| parent | perf intel-pt/bts: Define JITDUMP_USE_ARCH_TIMESTAMP (diff) | |
| download | kernel-qcow2-linux-ac0e2cd555373ae6f8f3a3ad3fbbf5b6d1e7aaaa.tar.gz kernel-qcow2-linux-ac0e2cd555373ae6f8f3a3ad3fbbf5b6d1e7aaaa.tar.xz kernel-qcow2-linux-ac0e2cd555373ae6f8f3a3ad3fbbf5b6d1e7aaaa.zip | |
perf tools: Fix PMU term format max value calculation
Currently the max value of format is calculated by the bits number. It
relies on the continuity of the format.
However, uncore event format is not continuous. E.g. uncore qpi event
format can be 0-7,21.
If bit 21 is set, there is parsing issues as below.
$ perf stat -a -e uncore_qpi_0/event=0x200002,umask=0x8/
event syntax error: '..pi_0/event=0x200002,umask=0x8/'
\___ value too big for format, maximum is 511
This patch return the real max value by setting all possible bits to 1.
Signed-off-by: Kan Liang <kan.liang@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Link: http://lkml.kernel.org/r/1459365375-14285-1-git-send-email-kan.liang@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/util/pmu.c')
| -rw-r--r-- | tools/perf/util/pmu.c | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c index adef23b1352e..bf34468a99cb 100644 --- a/tools/perf/util/pmu.c +++ b/tools/perf/util/pmu.c @@ -602,14 +602,13 @@ static void pmu_format_value(unsigned long *format, __u64 value, __u64 *v, static __u64 pmu_format_max_value(const unsigned long *format) { - int w; + __u64 w = 0; + int fbit; - w = bitmap_weight(format, PERF_PMU_FORMAT_BITS); - if (!w) - return 0; - if (w < 64) - return (1ULL << w) - 1; - return -1; + for_each_set_bit(fbit, format, PERF_PMU_FORMAT_BITS) + w |= (1ULL << fbit); + + return w; } /* |