summaryrefslogtreecommitdiffstats
path: root/tools/perf
diff options
context:
space:
mode:
authorMarkus Elfring2015-07-04 07:44:22 +0200
committerArnaldo Carvalho de Melo2015-07-06 13:58:36 +0200
commit200802a4a79b3a7a1cf924ad870d3265023d0787 (patch)
treee2175c2decf2733ce3597577fdbf4a07419396c3 /tools/perf
parentperf trace: Use event filters for the event qualifier list (diff)
downloadkernel-qcow2-linux-200802a4a79b3a7a1cf924ad870d3265023d0787.tar.gz
kernel-qcow2-linux-200802a4a79b3a7a1cf924ad870d3265023d0787.tar.xz
kernel-qcow2-linux-200802a4a79b3a7a1cf924ad870d3265023d0787.zip
perf probe: Delete an unnecessary check before the function call "strfilter__delete"
The strfilter__delete() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> Cc: Julia Lawall <julia.lawall@lip6.fr> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: kernel-janitors@vger.kernel.org Link: http://lkml.kernel.org/r/5597751A.5000506@users.sourceforge.net Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf')
-rw-r--r--tools/perf/builtin-probe.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
index 1272559fa22d..b81cec33b4b2 100644
--- a/tools/perf/builtin-probe.c
+++ b/tools/perf/builtin-probe.c
@@ -297,8 +297,7 @@ static void cleanup_params(void)
clear_perf_probe_event(params.events + i);
line_range__clear(&params.line_range);
free(params.target);
- if (params.filter)
- strfilter__delete(params.filter);
+ strfilter__delete(params.filter);
memset(&params, 0, sizeof(params));
}