summaryrefslogtreecommitdiffstats
path: root/tools/testing/selftests/ftrace/test.d/kprobe/uprobe_syntax_errors.tc
diff options
context:
space:
mode:
authorTom Zanussi2019-04-01 01:48:21 +0200
committerSteven Rostedt (VMware)2019-04-08 15:22:50 +0200
commitc5e4114fee0b6582b6e86804ffef95bf82bb5f78 (patch)
treec841db96850d0054cf79097350946bde48f5eaa4 /tools/testing/selftests/ftrace/test.d/kprobe/uprobe_syntax_errors.tc
parentselftests/ftrace: Add error_log testcase for probe errors (diff)
downloadkernel-qcow2-linux-c5e4114fee0b6582b6e86804ffef95bf82bb5f78.tar.gz
kernel-qcow2-linux-c5e4114fee0b6582b6e86804ffef95bf82bb5f78.tar.xz
kernel-qcow2-linux-c5e4114fee0b6582b6e86804ffef95bf82bb5f78.zip
selftests/ftrace: Move kprobe/uprobe check_error() to test.d/functions
The k/uprobe_sytax_errors test case defines a check_error() function used to run a command and check the position of the caret in the output. This would be useful for other ftrace facilities too, so move it to test.d/functions for use by anyone. In the process, rename it to ftrace_errlog_check() and parametrize it for general use. Link: http://lkml.kernel.org/r/9f88080a06f1755811f69081926afe7e5cb53178.1554072478.git.tom.zanussi@linux.intel.com Acked-by: Masami Hiramatsu <mhiramat@kernel.org> Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Diffstat (limited to 'tools/testing/selftests/ftrace/test.d/kprobe/uprobe_syntax_errors.tc')
-rw-r--r--tools/testing/selftests/ftrace/test.d/kprobe/uprobe_syntax_errors.tc10
1 files changed, 1 insertions, 9 deletions
diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/uprobe_syntax_errors.tc b/tools/testing/selftests/ftrace/test.d/kprobe/uprobe_syntax_errors.tc
index ec7389b7934b..14229d5778a0 100644
--- a/tools/testing/selftests/ftrace/test.d/kprobe/uprobe_syntax_errors.tc
+++ b/tools/testing/selftests/ftrace/test.d/kprobe/uprobe_syntax_errors.tc
@@ -7,15 +7,7 @@
[ -f error_log ] || exit_unsupported
check_error() { # command-with-error-pos-by-^
-pos=$(echo -n "${1%^*}" | wc -c) # error position
-command=$(echo "$1" | tr -d ^)
-echo "Test command: $command"
-echo > error_log
-(! echo "$command" > uprobe_events ) 2> /dev/null
-grep "trace_uprobe: error:" -A 3 error_log
-N=$(tail -n 1 error_log | wc -c)
-# " Command: " and "^\n" => 13
-test $(expr 13 + $pos) -eq $N
+ ftrace_errlog_check 'trace_uprobe' "$1" 'uprobe_events'
}
check_error 'p ^/non_exist_file:100' # FILE_NOT_FOUND