diff options
| author | Ilya Leoshkevich | 2019-07-19 11:06:11 +0200 |
|---|---|---|
| committer | Daniel Borkmann | 2019-07-22 16:19:06 +0200 |
| commit | c8eee4135a456bc031d67cadc454e76880d1afd8 (patch) | |
| tree | 3ef0a666cd0c14b5bfd86aa5a60917998722f20f /tools | |
| parent | libbpf: Avoid designated initializers for unnamed union members (diff) | |
| download | kernel-qcow2-linux-c8eee4135a456bc031d67cadc454e76880d1afd8.tar.gz kernel-qcow2-linux-c8eee4135a456bc031d67cadc454e76880d1afd8.tar.xz kernel-qcow2-linux-c8eee4135a456bc031d67cadc454e76880d1afd8.zip | |
selftests/bpf: fix sendmsg6_prog on s390
"sendmsg6: rewrite IP & port (C)" fails on s390, because the code in
sendmsg_v6_prog() assumes that (ctx->user_ip6[0] & 0xFFFF) refers to
leading IPv6 address digits, which is not the case on big-endian
machines.
Since checking bitwise operations doesn't seem to be the point of the
test, replace two short comparisons with a single int comparison.
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Acked-by: Andrey Ignatov <rdna@fb.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/testing/selftests/bpf/progs/sendmsg6_prog.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/tools/testing/selftests/bpf/progs/sendmsg6_prog.c b/tools/testing/selftests/bpf/progs/sendmsg6_prog.c index 5aeaa284fc47..a68062820410 100644 --- a/tools/testing/selftests/bpf/progs/sendmsg6_prog.c +++ b/tools/testing/selftests/bpf/progs/sendmsg6_prog.c @@ -41,8 +41,7 @@ int sendmsg_v6_prog(struct bpf_sock_addr *ctx) } /* Rewrite destination. */ - if ((ctx->user_ip6[0] & 0xFFFF) == bpf_htons(0xFACE) && - ctx->user_ip6[0] >> 16 == bpf_htons(0xB00C)) { + if (ctx->user_ip6[0] == bpf_htonl(0xFACEB00C)) { ctx->user_ip6[0] = bpf_htonl(DST_REWRITE_IP6_0); ctx->user_ip6[1] = bpf_htonl(DST_REWRITE_IP6_1); ctx->user_ip6[2] = bpf_htonl(DST_REWRITE_IP6_2); |