diff options
| author | Julia Lawall | 2009-11-21 12:51:47 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2009-12-11 20:55:26 +0100 |
| commit | 06e182911da95a304eaab71288a47bc5c799c4eb (patch) | |
| tree | 6eb6fa0527c05331ce97db6bc81577f89d58fe6b /usr/gen_init_cpio.c | |
| parent | USB: add remove_id sysfs attr for usb drivers (diff) | |
| download | kernel-qcow2-linux-06e182911da95a304eaab71288a47bc5c799c4eb.tar.gz kernel-qcow2-linux-06e182911da95a304eaab71288a47bc5c799c4eb.tar.xz kernel-qcow2-linux-06e182911da95a304eaab71288a47bc5c799c4eb.zip | |
USB: xhci-mem.c: introduce missing kfree
Error handling code following a kzalloc should free the allocated data.
The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,f1,l;
position p1,p2;
expression *ptr != NULL;
@@
x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
when != if (...) { <+...x...+> }
(
x->f1 = E
|
(x->f1 == NULL || ...)
|
f(...,x->f1,...)
)
...>
(
return \(0\|<+...x...+>\|ptr\);
|
return@p2 ...;
)
@script:python@
p1 << r.p1;
p2 << r.p2;
@@
print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'usr/gen_init_cpio.c')
0 files changed, 0 insertions, 0 deletions