diff options
| author | Punit Agrawal | 2018-10-01 17:54:35 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2018-11-13 20:08:47 +0100 |
| commit | 3e286d39ccd799e271c215b2e6633f19d34d910b (patch) | |
| tree | 53e97fcfcac9ae7740bb2b70e9f0c82c93686ce8 /virt | |
| parent | mm/hmm: fix race between hmm_mirror_unregister() and mmu_notifier callback (diff) | |
| download | kernel-qcow2-linux-3e286d39ccd799e271c215b2e6633f19d34d910b.tar.gz kernel-qcow2-linux-3e286d39ccd799e271c215b2e6633f19d34d910b.tar.xz kernel-qcow2-linux-3e286d39ccd799e271c215b2e6633f19d34d910b.zip | |
KVM: arm/arm64: Ensure only THP is candidate for adjustment
commit fd2ef358282c849c193aa36dadbf4f07f7dcd29b upstream.
PageTransCompoundMap() returns true for hugetlbfs and THP
hugepages. This behaviour incorrectly leads to stage 2 faults for
unsupported hugepage sizes (e.g., 64K hugepage with 4K pages) to be
treated as THP faults.
Tighten the check to filter out hugetlbfs pages. This also leads to
consistently mapping all unsupported hugepage sizes as PTE level
entries at stage 2.
Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
Reviewed-by: Suzuki Poulose <suzuki.poulose@arm.com>
Cc: Christoffer Dall <christoffer.dall@arm.com>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: stable@vger.kernel.org # v4.13+
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'virt')
| -rw-r--r-- | virt/kvm/arm/mmu.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/virt/kvm/arm/mmu.c b/virt/kvm/arm/mmu.c index ed162a6c57c5..2f405b0be25c 100644 --- a/virt/kvm/arm/mmu.c +++ b/virt/kvm/arm/mmu.c @@ -1230,8 +1230,14 @@ static bool transparent_hugepage_adjust(kvm_pfn_t *pfnp, phys_addr_t *ipap) { kvm_pfn_t pfn = *pfnp; gfn_t gfn = *ipap >> PAGE_SHIFT; + struct page *page = pfn_to_page(pfn); - if (PageTransCompoundMap(pfn_to_page(pfn))) { + /* + * PageTransCompoungMap() returns true for THP and + * hugetlbfs. Make sure the adjustment is done only for THP + * pages. + */ + if (!PageHuge(page) && PageTransCompoundMap(page)) { unsigned long mask; /* * The address we faulted on is backed by a transparent huge |