summaryrefslogtreecommitdiffstats
path: root/drivers/staging/rtl8188eu
Commit message (Collapse)AuthorAgeFilesLines
* staging: rtl8188eu: Convert to using IFF_NO_QUEUEPhil Sutter2016-04-171-1/+1
| | | | | | Cc: Jakub Sitnicki <jsitnicki@gmail.com> Signed-off-by: Phil Sutter <phil@nwl.cc> Signed-off-by: David S. Miller <davem@davemloft.net>
* Staging: rtl8188eu: Remove function rtw_freq2chBhumika Goyal2016-03-122-18/+0Star
| | | | | | | | Remove function rtw_freq2ch as it is never used anywhere in the kernel. Also, remove the function prototype. Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: rtl8188eu: removed unnecessary check in core/rtw_ap.cClaudiu Beznea2016-03-121-67/+64Star
| | | | | | | | | This patch removes unnecessary "if (true)" check in update_BCNTIM() from core/rtw_ap.c file. After this remove the code alignment was necessary. Signed-off-by: Claudiu Beznea <claudiu.beznea@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: os_dep: Remove unnecessary else after returnBhaktipriya Shridhar2016-03-121-2/+1Star
| | | | | | | | | | | | | | | | | This patch fixes the checkpatch warning that else is not generally useful after a break or return. This was done using Coccinelle: @@ expression e2; statement s1; @@ if(e2) { ... return ...; } -else s1 Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: rtl8188eu: Use !x instead of x==NULL.Sandhya Bankar2016-03-121-2/+2
| | | | | | | Use !x instead of x==NULL. Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: rtl8188eu: rtw_efuse: Do not print message if kzalloc() failed.Sandhya Bankar2016-03-121-3/+1Star
| | | | | | | | Do not print message if kzalloc() failed. kzalloc() has its own messages. So no need to add extra one. Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: rtl8188eu: Do not print message if kzalloc() failed.Sandhya Bankar2016-03-121-2/+1Star
| | | | | | | | Do not print message if kzalloc() failed. kzalloc() has its own messages. So no need to add extra one. Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* rtl8188eu: Add spaces around arithmetic operatorsKyle Kuffermann2016-03-121-44/+44
| | | | | | | This fixes the checkpatch.pl issue: CHECK: spaces preferred around that '+' Signed-off-by: Kyle Kuffermann <kyle.kuffermann@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: remove PWR_BASEADDR_* macro definitions and "base" ↵Ivan Safonov2016-03-123-114/+63Star
| | | | | | | | | | member of wl_pwr_cfg structure These macros and "base" member of wl_pwr_cfg structure are used only to produce debug output. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: remove PWR_INTF_*_MSK macro definitions and ↵Ivan Safonov2016-03-124-108/+57Star
| | | | | | | | | interface_mask of wl_pwr_cfg structure This driver is intended only for usb devices. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: remove PWR_FAB_*_MSK macro definitions and fab_msk of ↵Ivan Safonov2016-03-124-89/+77Star
| | | | | | | | | | | | | | wl_pwr_cfg structure fab_msk used for marking commands for devices of a certain manufacturer. However, always used only PWR_FAB_ALL_MSK value of fab_msk. Most likely, such mark is useless. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: remove FabVersion member of odm_dm_struct structIvan Safonov2016-03-123-16/+1Star
| | | | | | | | | Value of this variable is hardcoded and used only to produce debug output. Probably, FabVersion is useless. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: remove chip_type of the adapter structureIvan Safonov2016-03-122-3/+0Star
| | | | | | | | | chip_type variable is unnecessary here, because this driver is only for one chip and it is not used after initialization. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: replace (a == NULL) to (!a) in rtw_drv_initIvan Safonov2016-03-121-2/+2
| | | | | | | | It is a checkpatch cleanups: CHECK: Comparasion to NULL could be written ... Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: remove unnecessary debug output from os_dep/usb_intf.cIvan Safonov2016-03-121-4/+0Star
| | | | | | | Debug output in rtw_drw_init is excess Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: remove unused macros from include/basic_types.hIvan Safonov2016-03-121-29/+0Star
| | | | | | | | FIELD_OFFSET, READEF1BYTE, READEF2BYTE, READEF4BYTE WRITEEF1BYTE, WRITEEF2BYTE, WRITEEF4BYTE are removed. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: remove unused include/ieee80211_ext.hIvan Safonov2016-03-121-290/+0Star
| | | | | | | This file is not used for the driver compiling Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: FIELD_OFFSET macro replaced by offsetof macroIvan Safonov2016-03-123-7/+7
| | | | | | | FIELD_OFFSET and offsetof macro are equal Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: os_dep: Remove NULL test before vfreeBhaktipriya Shridhar2016-03-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | vfree frees the virtually continuous memory area starting at addr. If addr is NULL, no operation is performed. So NULL test is not needed before vfree. This was done using Coccinelle: @@ expression x; @@ -if (x != NULL) vfree(x); @@ expression x; @@ -if (x != NULL) { vfree(x); x = NULL; -} Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: core: Remove NULL test before vfreeBhaktipriya Shridhar2016-03-122-4/+2Star
| | | | | | | | | | | | | | | | | | | | | | | | | | vfree frees the virtually continuous memory area starting at addr. If addr is NULL, no operation is performed. So NULL test is not needed before vfree. This was done using Coccinelle: @@ expression x; @@ -if (x != NULL) vfree(x); @@ expression x; @@ -if (x != NULL) { vfree(x); x = NULL; -} Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: core: Remove useless return variablesBhaktipriya Shridhar2016-03-121-3/+1Star
| | | | | | | | | | | | | | | | | | | | | This patch removes unnecessary return variables and compresses the return logic. The coccinelle script that finds and fixes this issue is: @@ type T; identifier i,f; constant C; @@ - T i; ...when != i when strict ( return -C; | - i = + return f(...); - return i; ) Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: os_dep: Remove useless return variablesBhaktipriya Shridhar2016-03-121-4/+1Star
| | | | | | | | | | | | | | | | | | | | This patch removes unnecessary return variables and compresses the return logic. The coccinelle script that finds and fixes this issue is: @@ type T; identifier i,f; constant C; @@ - T i; ...when != i when strict ( return -C; | - i = + return f(...); - return i; ) Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: core: Remove casts of pointer to same typeBhaktipriya Shridhar2016-03-121-5/+5
| | | | | | | | | | | | | | | | | Casting a pointer to a pointer of the same type is unnecessary, so remove these unnecessary casts. This was done with Coccinelle: @@ type T; T *ptr; @@ - (T *)ptr + ptr Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: hal: Drop Useless InitializationBhaktipriya Shridhar2016-03-121-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | Removed initialisation of a varible if it is immediately reassigned. Changes were made using Coccinelle. @bad@ identifier i; position p; @@ i =@p <+...i...+>; @@ type T; constant C; expression e; identifier i; position p != bad.p; @@ T i - = C ; i =@p e; Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: Remove unnecessary paranthesesBhaktipriya Shridhar2016-03-121-1/+1
| | | | | | | | | | | | | | | | | | Removed parantheses on the right hand side of assignments as they are not needed. This was done with Coccinelle: @@ expression a, b; @@ a = - ( b - ) ; Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: os_dep: Remove header fileAmitoj Kaur Chawla2016-02-221-1/+0Star
| | | | | | | Remove duplicate include file. Found using includecheck. Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: core: Remove unnecessary bracesBhaktipriya Shridhar2016-02-211-8/+4Star
| | | | | | | | | | | | | | | | | | This patch removes braces for single statement blocks. The warning was detected using checkpatch.pl. Coccinelle was used to make the change. @@ expression e,e1; @@ - if (e) { + if (e) e1; - } Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: Remove RF_PATH_C & RF_PATH_DAndrew Bradford2016-02-213-54/+0Star
| | | | | | | | RTL8188EE has a maximum of 2 RF paths (chains) so paths C and D are not needed to support this part. Signed-off-by: Andrew Bradford <andrew@bradfordembedded.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: rtl8188eu/core: Coding style fix, avoid line over 80 charactersColin Vidal2016-02-211-1/+2
| | | | | | | | Jump a new line after and operator of the test. It avoids to exceed 80 chars line, and remove a checkpatch warning. Signed-off-by: Colin Vidal <colin@cvidal.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: rtl8188eu/core: Coding style fix, set constant operand on right in ↵Colin Vidal2016-02-211-2/+2
| | | | | | | | | tests Remove a checkpatch warning, putting constant operant on right of two tests. Signed-off-by: Colin Vidal <colin@cvidal.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: rtl8188eu/core: Coding style fix, set conform spaces between ↵Colin Vidal2016-02-211-2/+2
| | | | | | | | | | | identifiers And a space after include keyword, making the preprocessor more readable, and remove an unexpected space between a type and variable name. Signed-off-by: Colin Vidal <colin@cvidal.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: rtl8188eu/core: remove paragraph which mention FSF address in ↵Colin Vidal2016-02-211-4/+0Star
| | | | | | | | | | | comment header As FSF address changed in the past, and can change in the future, remove the address paragraph in the comment header, and avoid a warning of checkpatch. Signed-off-by: Colin Vidal <colin@cvidal.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: core: Use put_unaligned_le16Amitoj Kaur Chawla2016-02-211-3/+2Star
| | | | | | | | | | | | | | | | | | | | | | | | | | | Introduce the use of function put_unaligned_le16. This is done using the following Coccinelle semantic patch: //<smpl> @@ identifier tmp; expression ptr; expression y,e; type T; @@ - tmp = cpu_to_le16(y); <+... when != tmp - memcpy(ptr, (T)&tmp, ...); + put_unaligned_le16(y,ptr); ...+> ? tmp = e @@ type T; identifier tmp; @@ - T tmp; ...when != tmp //</smpl> Corresponding header file has been added too. Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: rtl8188eu: core: rtw_xmit.c: Remove NULL test before vfreeBhumika Goyal2016-02-211-5/+2Star
| | | | | | | | | The function vfree tests whether the argument is NULL and returns immediately. So NULL test is not needed before vfree. Also remove blank line between function calls. Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: rtl8188eu: core: rtw_mlme.c: Remove NULL test before vfreeBhumika Goyal2016-02-211-4/+2Star
| | | | | | | | | The function vfree tests whether the argument is NULL and returns immediately. So NULL test before vfree is not needed. Also remove braces around if branch as they are no longer needed. Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: rtl8188eu: os_dep: Remove NULL test before rtw_free_netdevBhumika Goyal2016-02-151-2/+1Star
| | | | | | | | The function rtw_free_netdev test whether its argument is NULL and return immediately. So NULL test before this function is not needed. Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: fix signal strength indicationAndrew Bradford2016-02-122-2/+2
| | | | | | | | | | | RTL8188E can only have a maximum of 2 chains so match that in the actual phy_rx_agc_info structure within phy_status_rpt. This will cause the other data received from the PHY, such as signal strength indication of beacons, to properly align and allow extraction and use within the signal strength record-keeping mechanisms. Signed-off-by: Andrew Bradford <andrew@bradfordembedded.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: add release_firmware() between request_firmware and ↵Ivan Safonov2016-02-121-1/+4
| | | | | | | | | function error exit Small memory leak fixed. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: remove pfirmware and fwsize of the hal_data_8188e structureIvan Safonov2016-02-123-17/+9Star
| | | | | | | | | | | | The pfirmware is used only in rtl88eu_download_fw function (except the kfree(rtlhal->pfirmware) in netdev_close). The fwsize not used after initialization at all. The pfirmvare replaced by fw_data and fwsize removed. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: remove _rtl88e_fill_dummyIvan Safonov2016-02-121-25/+20Star
| | | | | | | | | | | | The _rtl88e_fill_dummy function replaced by memset in rtl88eu_download_fw. More appropriate names are used for pfwdata and fwsize variables (download_data and download_size respectively). Also u32 replaced by size_t for download_size variable. Signed-off-by: Ivan Safonov <insafonov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: Remove unnecessary pointer castJanani Ravichandran2016-02-121-1/+1
| | | | | | | | | | | | | | | Remove unnecessary pointer cast. Issue found using the following Coccinelle semantic patch. @@ type T; T e; identifier x; @@ * T x = (T)e; Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8*: fix my email address upGreg Kroah-Hartman2016-02-121-1/+1
| | | | | | | | For some reason I had an old linux.com address in these TODO files, point to my linuxfoundation.org address as that works properly here. Reported-by: Luca Ceresoli <luca@lucaceresoli.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: use eth_broadcast_addr() in place of memsetHari Prasath Gujulan Elango2016-02-081-1/+1
| | | | | | | | Replace the memset of array to broadcast address 0xFF by using the eth_broadcast_addr() API Signed-off-by: Hari Prasath Gujulan Elango <hgujulan@visteon.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: use list_first_entry_or_null()Geliang Tang2016-02-085-105/+48Star
| | | | | | | | Use list_first_entry_or_null() instead of list_empty() + container_of() to simplify the code. Signed-off-by: Geliang Tang <geliangtang@163.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: print OUI with %*phAndy Shevchenko2016-02-081-2/+2
| | | | | | | | There is no need to pass each byte as a parameter when printing values in hex format. We rather use %*ph specifier for that. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: replace open-coded print_hex_dump()Andy Shevchenko2016-02-081-23/+16Star
| | | | | | | | No need to reinvent a wheel, i.e. print_hex_dump(). Replace an open-coded variant by generic kernel helper. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: provide an absolute path to include folderAndy Shevchenko2016-02-081-1/+1
| | | | | | | | | | Otherwise compiler will complain as follows CC [M] drivers/staging/rtl8188eu/core/rtw_ap.o cc1: warning: drivers/staging/rtl8188eu/include: No such file or directory [-Wmissing-include-dirs] Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: rtl8188eu: core: rtw_debug: fixed a parentheses coding style issueChris Elliott2016-02-081-7/+7
| | | | | | | Removed unnecessary parentheses. Signed-off-by: Chris Elliott <chris@uksysadmin.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: remove an extra spaceAlexey Tulia2016-02-081-1/+1
| | | | | | | drivers/staging/rtl8188eu/core/rtw_wlan_util.c:1377 check_assoc_AP() warn: inconsistent indenting Signed-off-by: Alexey Tulia <alexey.tulia@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8188eu: rtw_mlme_ext.c: simplify call to issue_action_BA()Luca Ceresoli2016-02-081-4/+4
| | | | | | | | | | Using the ternary operator allows to more concisely write the same code, and to stay within 80 characters without even increasing the number of lines. Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> Cc: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
generated by cgit v1.2.3-55-g7522 (git 2.39.0) at 2024-07-23 08:27:03 +0200