summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKarel Zak2018-07-03 13:51:51 +0200
committerKarel Zak2018-07-03 13:51:51 +0200
commit562adaed911db581fe01664c07a27184e27087c3 (patch)
tree14db42c59024edf018e2656f6a2f49d757b7c98b
parentdocs: update TODO (diff)
downloadkernel-qcow2-util-linux-562adaed911db581fe01664c07a27184e27087c3.tar.gz
kernel-qcow2-util-linux-562adaed911db581fe01664c07a27184e27087c3.tar.xz
kernel-qcow2-util-linux-562adaed911db581fe01664c07a27184e27087c3.zip
fallocate: add man page note about --collapse-range granularity
Reported-by: Radka Skvarilova <rskvaril@redhat.com> Signed-off-by: Karel Zak <kzak@redhat.com>
-rw-r--r--sys-utils/fallocate.16
-rw-r--r--sys-utils/fallocate.c3
2 files changed, 9 insertions, 0 deletions
diff --git a/sys-utils/fallocate.1 b/sys-utils/fallocate.1
index d4821dcd1..fe5072ae8 100644
--- a/sys-utils/fallocate.1
+++ b/sys-utils/fallocate.1
@@ -72,6 +72,12 @@ The option
may not be specified for the collapse-range operation.
.sp
Available since Linux 3.15 for ext4 (only for extent-based files) and XFS.
+.sp
+A filesystem may place limitations on the granularity of the operation, in
+order to ensure efficient implementation. Typically, offset and len must be a
+multiple of the filesystem logical block size, which varies according to the
+filesystem type and configuration. If a filesystem has such a requirement,
+the operation will fail with the error EINVAL if this requirement is violated.
.TP
.BR \-d ", " \-\-dig\-holes
Detect and dig holes.
diff --git a/sys-utils/fallocate.c b/sys-utils/fallocate.c
index c6bed63ef..c97e63d4b 100644
--- a/sys-utils/fallocate.c
+++ b/sys-utils/fallocate.c
@@ -121,6 +121,9 @@ static loff_t cvtnum(char *s)
static void xfallocate(int fd, int mode, off_t offset, off_t length)
{
int error;
+
+fprintf(stderr, "KZAK>>> %d\n", mode);
+
#ifdef HAVE_FALLOCATE
error = fallocate(fd, mode, offset, length);
#else