summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJ William Piggott2017-03-26 17:56:42 +0200
committerJ William Piggott2017-03-31 16:04:53 +0200
commitaf68bd014ab4f0eef8ef34f69365905385fd3b21 (patch)
tree374d37bc79ad6796bbc1b156799b54085a5270e2
parenthwclock: remove dead cmos code (diff)
downloadkernel-qcow2-util-linux-af68bd014ab4f0eef8ef34f69365905385fd3b21.tar.gz
kernel-qcow2-util-linux-af68bd014ab4f0eef8ef34f69365905385fd3b21.tar.xz
kernel-qcow2-util-linux-af68bd014ab4f0eef8ef34f69365905385fd3b21.zip
hwclock: remove unused 'silent' arg
The 'silent' argument for get_epoch_rtc() was used to silence error messages when querying the rtc driver for an alpha epoch while using cmos direct access. Alpha cmos has since been removed so 'silent' is no longer used. * sys-utils/hwclock.h: remove 'silent' argument * sys-utils/hwclock.c: same * sys-utils/hwclock-rtc.c: same Signed-off-by: J William Piggott <elseifthen@gmx.com>
-rw-r--r--sys-utils/hwclock-rtc.c20
-rw-r--r--sys-utils/hwclock.c2
-rw-r--r--sys-utils/hwclock.h2
3 files changed, 10 insertions, 14 deletions
diff --git a/sys-utils/hwclock-rtc.c b/sys-utils/hwclock-rtc.c
index 077db73e7..f2728284d 100644
--- a/sys-utils/hwclock-rtc.c
+++ b/sys-utils/hwclock-rtc.c
@@ -396,27 +396,23 @@ struct clock_ops *probe_for_rtc_clock(const struct hwclock_control *ctl)
/*
* Get the Hardware Clock epoch setting from the kernel.
*/
-int get_epoch_rtc(const struct hwclock_control *ctl, unsigned long *epoch_p,
- int silent)
+int get_epoch_rtc(const struct hwclock_control *ctl, unsigned long *epoch_p)
{
int rtc_fd;
rtc_fd = open_rtc(ctl);
if (rtc_fd < 0) {
- if (!silent) {
- if (errno == ENOENT)
- warnx(_
- ("To manipulate the epoch value in the kernel, we must "
- "access the Linux 'rtc' device driver via the device special "
- "file. This file does not exist on this system."));
- else
- warn(_("cannot open rtc device"));
- }
+ if (errno == ENOENT)
+ warnx(_
+ ("To manipulate the epoch value in the kernel, we must "
+ "access the Linux 'rtc' device driver via the device special "
+ "file. This file does not exist on this system."));
+ else
+ warn(_("cannot open rtc device"));
return 1;
}
if (ioctl(rtc_fd, RTC_EPOCH_READ, epoch_p) == -1) {
- if (!silent)
warn(_("ioctl(RTC_EPOCH_READ) to %s failed"),
rtc_dev_name);
return 1;
diff --git a/sys-utils/hwclock.c b/sys-utils/hwclock.c
index 8914f9445..3875bcc54 100644
--- a/sys-utils/hwclock.c
+++ b/sys-utils/hwclock.c
@@ -1190,7 +1190,7 @@ manipulate_epoch(const struct hwclock_control *ctl)
if (ctl->getepoch) {
unsigned long epoch;
- if (get_epoch_rtc(ctl, &epoch, 0))
+ if (get_epoch_rtc(ctl, &epoch))
warnx(_
("Unable to get the epoch value from the kernel."));
else
diff --git a/sys-utils/hwclock.h b/sys-utils/hwclock.h
index f090ed7ca..37e817314 100644
--- a/sys-utils/hwclock.h
+++ b/sys-utils/hwclock.h
@@ -67,7 +67,7 @@ extern unsigned long epoch_option;
extern double time_diff(struct timeval subtrahend, struct timeval subtractor);
/* rtc.c */
-extern int get_epoch_rtc(const struct hwclock_control *ctl, unsigned long *epoch, int silent);
+extern int get_epoch_rtc(const struct hwclock_control *ctl, unsigned long *epoch);
extern int set_epoch_rtc(const struct hwclock_control *ctl);
extern void hwclock_exit(const struct hwclock_control *ctl, int status);