summaryrefslogtreecommitdiffstats
path: root/bash-completion/fsck
diff options
context:
space:
mode:
authorSami Kerola2014-10-26 23:07:08 +0100
committerKarel Zak2014-10-31 10:39:00 +0100
commit53154dae39cd16924c97754589ed5396a91946bd (patch)
tree2db36d7308a6b16abcf570fba3b435517c63b334 /bash-completion/fsck
parentfstrim: initialize path variable (diff)
downloadkernel-qcow2-util-linux-53154dae39cd16924c97754589ed5396a91946bd.tar.gz
kernel-qcow2-util-linux-53154dae39cd16924c97754589ed5396a91946bd.tar.xz
kernel-qcow2-util-linux-53154dae39cd16924c97754589ed5396a91946bd.zip
bash-completion: stop being clever when listing block devices
Various commands such as blkid, cfdisk, fdisk, delpart, and so on listed only partitions and missed for example disks and volume groups. The right thing to do is to list all block devices in all for all commands performing operations with them. This might occasionally list unexpected devices that I think is lesser bad than missing some. Addresses: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=764488 Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Diffstat (limited to 'bash-completion/fsck')
-rw-r--r--bash-completion/fsck3
1 files changed, 1 insertions, 2 deletions
diff --git a/bash-completion/fsck b/bash-completion/fsck
index 04899a0d1..d61b37f42 100644
--- a/bash-completion/fsck
+++ b/bash-completion/fsck
@@ -32,8 +32,7 @@ _fsck_module()
return 0
;;
esac
- while read dev; do DEVS+="$dev " ; done < <(lsblk -pnro name)
- COMPREPLY=( $(compgen -W "$DEVS" -- $cur) )
+ COMPREPLY=( $(compgen -W "$(lsblk -pnro name)" -- $cur) )
return 0
}
complete -F _fsck_module fsck