summaryrefslogtreecommitdiffstats
path: root/libmount/src/context_umount.c
diff options
context:
space:
mode:
authorDave Reisner2013-09-18 16:15:29 +0200
committerKarel Zak2013-09-20 10:06:01 +0200
commit2afcbe139d272fa494c28c8e6a0624d93a96e157 (patch)
tree41125426ccc41ef66de5c636165a84449ede4a78 /libmount/src/context_umount.c
parentlibmount: use memmove when overlap possible (diff)
downloadkernel-qcow2-util-linux-2afcbe139d272fa494c28c8e6a0624d93a96e157.tar.gz
kernel-qcow2-util-linux-2afcbe139d272fa494c28c8e6a0624d93a96e157.tar.xz
kernel-qcow2-util-linux-2afcbe139d272fa494c28c8e6a0624d93a96e157.zip
libmount: free username after check
Leak reported by valgrind: ==14226== 7 bytes in 1 blocks are definitely lost in loss record 1 of 1 ==14226== at 0x4C2757B: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==14226== by 0x5534839: strdup (in /usr/lib/libc-2.18.so) ==14226== by 0x4E53FE0: mnt_get_username (utils.c:560) ==14226== by 0x4E456A5: mnt_context_prepare_umount (context_umount.c:413) ==14226== by 0x4E464F7: mnt_context_umount (context_umount.c:851) ==14226== by 0x403476: umount_one (umount.c:299) ==14226== by 0x402B34: main (umount.c:629) Signed-off-by: Dave Reisner <dreisner@archlinux.org>
Diffstat (limited to 'libmount/src/context_umount.c')
-rw-r--r--libmount/src/context_umount.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/libmount/src/context_umount.c b/libmount/src/context_umount.c
index 2e912c0dc..766adfde1 100644
--- a/libmount/src/context_umount.c
+++ b/libmount/src/context_umount.c
@@ -423,6 +423,8 @@ static int evaluate_permissions(struct libmnt_context *cxt)
if (optstr && !mnt_optstr_get_option(optstr,
"user", &mtab_user, &sz) && sz)
ok = !strncmp(curr_user, mtab_user, sz);
+
+ free(curr_user);
}
if (ok) {