summaryrefslogtreecommitdiffstats
path: root/login-utils/login.c
diff options
context:
space:
mode:
authorSami Kerola2013-02-20 22:31:09 +0100
committerKarel Zak2013-03-04 12:28:34 +0100
commit747168d4441ccff1b222b72d8b7478215d76d8fd (patch)
treec0ea76f735c71f28f89df49f830d4b00e01e31b9 /login-utils/login.c
parentwall: use xgethostname() (diff)
downloadkernel-qcow2-util-linux-747168d4441ccff1b222b72d8b7478215d76d8fd.tar.gz
kernel-qcow2-util-linux-747168d4441ccff1b222b72d8b7478215d76d8fd.tar.xz
kernel-qcow2-util-linux-747168d4441ccff1b222b72d8b7478215d76d8fd.zip
login: remove file descriptor leak [cppcheck]
[login-utils/login.c:510]: (error) Resource leak: fd Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Diffstat (limited to 'login-utils/login.c')
-rw-r--r--login-utils/login.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/login-utils/login.c b/login-utils/login.c
index a17083b5f..425053406 100644
--- a/login-utils/login.c
+++ b/login-utils/login.c
@@ -506,8 +506,10 @@ static void log_lastlog(struct login_context *cxt)
if (fd < 0)
return;
- if (lseek(fd, (off_t) cxt->pwd->pw_uid * sizeof(ll), SEEK_SET) == -1)
+ if (lseek(fd, (off_t) cxt->pwd->pw_uid * sizeof(ll), SEEK_SET) == -1) {
+ close(fd);
return;
+ }
/*
* Print last log message