diff options
| author | Yuriy M. Kaminskiy | 2016-02-27 17:27:29 +0100 |
|---|---|---|
| committer | Karel Zak | 2016-03-07 15:11:06 +0100 |
| commit | 06fa5817489adb9728f8a29d4cb7602fb48b8bdb (patch) | |
| tree | b3a6f1d0db6b1a6d0e340c1297f243c07c1de618 /login-utils/lslogins.c | |
| parent | lsns.c: fix error return (diff) | |
| download | kernel-qcow2-util-linux-06fa5817489adb9728f8a29d4cb7602fb48b8bdb.tar.gz kernel-qcow2-util-linux-06fa5817489adb9728f8a29d4cb7602fb48b8bdb.tar.xz kernel-qcow2-util-linux-06fa5817489adb9728f8a29d4cb7602fb48b8bdb.zip | |
misc: safer (and uniform) handling of return value
When `rc` is `INT_MAX`, `rc + 1` result in signed integer overflow.
Signed-off-by: Karel Zak <kzak@redhat.com>
Diffstat (limited to 'login-utils/lslogins.c')
| -rw-r--r-- | login-utils/lslogins.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/login-utils/lslogins.c b/login-utils/lslogins.c index f9b9d401d..40a134308 100644 --- a/login-utils/lslogins.c +++ b/login-utils/lslogins.c @@ -397,7 +397,7 @@ again: x = snprintf(p, len, "%s,", grp->gr_name); } - if (x < 0 || (size_t) x + 1 > len) { + if (x < 0 || (size_t) x >= len) { size_t cur = p - res; maxlen *= 2; |