summaryrefslogtreecommitdiffstats
path: root/login-utils/newgrp.c
diff options
context:
space:
mode:
authorKarel Zak2012-02-02 14:13:45 +0100
committerKarel Zak2012-02-02 14:13:45 +0100
commitc6f23b3ba1665177f4b7c5e15268965ebf383698 (patch)
treea2be290d91fc91b4e52a51bd53936ed2e8320fbe /login-utils/newgrp.c
parentfindmnt: initialize rc variable (diff)
downloadkernel-qcow2-util-linux-c6f23b3ba1665177f4b7c5e15268965ebf383698.tar.gz
kernel-qcow2-util-linux-c6f23b3ba1665177f4b7c5e15268965ebf383698.tar.xz
kernel-qcow2-util-linux-c6f23b3ba1665177f4b7c5e15268965ebf383698.zip
login: (and chsh) make pw_shell usage more robust
Signed-off-by: Karel Zak <kzak@redhat.com>
Diffstat (limited to 'login-utils/newgrp.c')
-rw-r--r--login-utils/newgrp.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/login-utils/newgrp.c b/login-utils/newgrp.c
index 85cba7752..983993416 100644
--- a/login-utils/newgrp.c
+++ b/login-utils/newgrp.c
@@ -138,7 +138,8 @@ int main(int argc, char *argv[])
if (!(pw_entry = getpwuid(getuid())))
err(EXIT_FAILURE, _("who are you?"));
- shell = (pw_entry->pw_shell[0] ? pw_entry->pw_shell : _PATH_BSHELL);
+ shell = (pw_entry->pw_shell && *pw_entry->pw_shell ?
+ pw_entry->pw_shell : _PATH_BSHELL);
if (argc < 2) {
if (setgid(pw_entry->pw_gid) < 0)