summaryrefslogtreecommitdiffstats
path: root/login-utils/sulogin-consoles.c
diff options
context:
space:
mode:
authorKarel Zak2015-01-29 11:32:42 +0100
committerKarel Zak2015-01-29 11:32:42 +0100
commit863d371c83fe8ca59f1a2cef3ce4d7b66b06dd99 (patch)
tree9e2c60b5b336c310516903b3cf37d4d7e11d0b58 /login-utils/sulogin-consoles.c
parentsu: fix mem leak in modify_environ() [coverity scan] (diff)
downloadkernel-qcow2-util-linux-863d371c83fe8ca59f1a2cef3ce4d7b66b06dd99.tar.gz
kernel-qcow2-util-linux-863d371c83fe8ca59f1a2cef3ce4d7b66b06dd99.tar.xz
kernel-qcow2-util-linux-863d371c83fe8ca59f1a2cef3ce4d7b66b06dd99.zip
sulogin: make sure that fallback FD is valid [coverity scan]
Signed-off-by: Karel Zak <kzak@redhat.com>
Diffstat (limited to 'login-utils/sulogin-consoles.c')
-rw-r--r--login-utils/sulogin-consoles.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/login-utils/sulogin-consoles.c b/login-utils/sulogin-consoles.c
index 817a882cf..9fd103405 100644
--- a/login-utils/sulogin-consoles.c
+++ b/login-utils/sulogin-consoles.c
@@ -594,7 +594,7 @@ int detect_consoles(const char *device, int fallback, struct list_head *consoles
consoles_debug = getenv("CONSOLES_DEBUG") ? 1 : 0;
if (!device || !*device)
- fd = dup(fallback);
+ fd = fallback >= 0 ? dup(fallback) : - 1;
else {
fd = open(device, O_RDWR|O_NONBLOCK|O_NOCTTY|O_CLOEXEC);
reconnect = 1;