summaryrefslogtreecommitdiffstats
path: root/sys-utils/ipcrm.c
diff options
context:
space:
mode:
authorSami Kerola2017-05-16 10:18:24 +0200
committerKarel Zak2017-06-14 11:48:22 +0200
commitb1557fe98120132e6671924af4ed69f4e21d3de4 (patch)
tree5b7a0e689fd4a09288f57c3a8eb4f24075ca65a3 /sys-utils/ipcrm.c
parentlibblkid: fix gcc-7 warning -Wint-in-bool-context (diff)
downloadkernel-qcow2-util-linux-b1557fe98120132e6671924af4ed69f4e21d3de4.tar.gz
kernel-qcow2-util-linux-b1557fe98120132e6671924af4ed69f4e21d3de4.tar.xz
kernel-qcow2-util-linux-b1557fe98120132e6671924af4ed69f4e21d3de4.zip
misc: fix ggc-7 fallthrough warnings
(Original patch and commit message edited by Rudi.) gcc-7 adds -Wimplicit-fallthrough=3 to our default flag -Wextra. This warning can be silenced by using comment /* fallthrough */ which is also recognized by other tools like coverity. There are also other valid comments (see man gcc-7) but we consolidate this style now. We could have also used __attribute__((fallthrough)) but the comment looks nice and does not need to be ifdef'ed for compatibility. Reference: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=7652 Reference: https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7/ Reviewed-by: Ruediger Meier <ruediger.meier@ga-group.nl> Suggested-by: Karel Zak <kzak@redhat.com> Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Diffstat (limited to 'sys-utils/ipcrm.c')
-rw-r--r--sys-utils/ipcrm.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/sys-utils/ipcrm.c b/sys-utils/ipcrm.c
index 0432b224f..5b71f7d81 100644
--- a/sys-utils/ipcrm.c
+++ b/sys-utils/ipcrm.c
@@ -346,6 +346,7 @@ int main(int argc, char **argv)
ret++;
break;
}
+ /* fallthrough */
case 'm':
if (!iskey)
id = strtos32_or_err(optarg, _("failed to parse argument"));
@@ -359,6 +360,7 @@ int main(int argc, char **argv)
ret++;
break;
}
+ /* fallthrough */
case 'q':
if (!iskey)
id = strtos32_or_err(optarg, _("failed to parse argument"));
@@ -372,6 +374,7 @@ int main(int argc, char **argv)
ret++;
break;
}
+ /* fallthrough */
case 's':
if (!iskey)
id = strtos32_or_err(optarg, _("failed to parse argument"));